Skip to content

[SPARK-26538][SQL] Set default precision and scale for elements of postgres numeric array #23456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
a-shkarupin wants to merge 4 commits into from
Closed

[SPARK-26538][SQL] Set default precision and scale for elements of postgres numeric array #23456

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b004ee3
[SPARK-26538][SQL] Set default precision and scale for elements of po…
a-shkarupin Jan 4, 2019
31b0b04
[SPARK-26538][SQL] add a comment explaining the issue
a-shkarupin Jan 8, 2019
77bbcb5
Add a test at PostgresIntegrationSuite
dongjoon-hyun Jan 5, 2019
c72e214
[SPARK-26538][SQL] follow existing style
a-shkarupin Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[SPARK-26538][SQL] follow existing style
  • Loading branch information
@a-shkarupin
a-shkarupin committed Jan 10, 2019
commit c72e2149bc421019692bf028784d2bd511b9e11c
6 changes: 2 additions & 4 deletions sql/core/src/main/scala/org/apache/spark/sql/jdbc/PostgresDialect.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,10 @@ private object PostgresDialect extends JdbcDialect {
case "bytea" => Some(BinaryType)
case "timestamp" | "timestamptz" | "time" | "timetz" => Some(TimestampType)
case "date" => Some(DateType)
case "numeric" | "decimal" => if (precision > 0) {
Some(DecimalType.bounded(precision, scale))
} else {
case "numeric" | "decimal" if precision > 0 => Some(DecimalType.bounded(precision, scale))
case "numeric" | "decimal" =>
// SPARK-26538: handle numeric without explicit precision and scale.
Some(DecimalType. SYSTEM_DEFAULT)
}
case _ => None
}

Expand Down