Skip to content

[SPARK-26551][SQL] Fix schema pruning error when selecting one complex field and having is not null predicate on another one #23474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 4 commits into from
Closed

[SPARK-26551][SQL] Fix schema pruning error when selecting one complex field and having is not null predicate on another one #23474

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f5a91a
Fix schema pruning error when selecting one complex field and having …
viirya Jan 6, 2019
6dbd753
Address comment.
viirya Jan 7, 2019
ff1cc85
Address comment.
viirya Jan 10, 2019
ff2fa67
Move optFieldType.
viirya Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comment.
  • Loading branch information
@viirya
viirya committed Jan 7, 2019
commit 6dbd753d679b3bdc7e88999019727cbb37e2bc33
10 changes: 1 addition & 9 deletions .../main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruning.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,11 @@ private[sql] object ParquetSchemaPruning extends Rule[LogicalPlan] {
plan
}

// `PhysicalOperation` pattern returns relation operator's outputs if there is no
// projects on it. In this case, we don't need to do schema pruning.
private def directOutput(projects: Seq[NamedExpression], plan: LogicalPlan): Boolean = {
projects.length == plan.output.length && projects.zip(plan.output).forall {
case (l, r) => l.name == r.name && l.dataType.sameType(r.dataType)
}
}

private def apply0(plan: LogicalPlan): LogicalPlan =
plan transformDown {
case op @ PhysicalOperation(projects, filters,
l @ LogicalRelation(hadoopFsRelation: HadoopFsRelation, _, _, _))
if canPruneRelation(hadoopFsRelation) && !directOutput(projects, l) =>
if canPruneRelation(hadoopFsRelation) =>
val (normalizedProjects, normalizedFilters) =
normalizeAttributeRefNames(l, projects, filters)
val requestedRootFields = identifyRootFields(normalizedProjects, normalizedFilters)
Expand Down