Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This fixes the compilation error.

$ cd resource-managers/kubernetes/integration-tests
$ mvn test-compile
[ERROR] /Users/dongjoon/APACHE/spark/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala:71: type mismatch;
 found   : org.apache.spark.internal.config.OptionalConfigEntry[Boolean]
 required: String
[ERROR]       .set(IS_TESTING, false)
[ERROR]            ^

How was this patch tested?

Pass the Jenkins K8S Integration test or Manual.

@SparkQA
Copy link

SparkQA commented Jan 10, 2019

Test build #101007 has finished for PR 23505 at commit 677ab2c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 10, 2019

@SparkQA
Copy link

SparkQA commented Jan 10, 2019

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/6884/

@dongjoon-hyun
Copy link
Member Author

K8S integration test passed.

cc @vanzin and @mgaido91 .

@dongjoon-hyun
Copy link
Member Author

Thank you for review and approval, @felixcheung .
Merged to master.

@mgaido91
Copy link
Contributor

a late LGTM, thanks for teh fix @dongjoon-hyun !

@dongjoon-hyun
Copy link
Member Author

Thanks, @mgaido91 .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-26491 branch January 10, 2019 08:37
@ifilonenko
Copy link
Contributor

I don't see this PR merged into master. My integration tests are still failing

@dongjoon-hyun
Copy link
Member Author

@ifilonenko .
Please see b316ebf

@ifilonenko
Copy link
Contributor

@dongjoon-hyun
Copy link
Member Author

Another commit breaks it again. I'll make a follow up for SPARK-26482.

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

This fixes the compilation error.

```
$ cd resource-managers/kubernetes/integration-tests
$ mvn test-compile
[ERROR] /Users/dongjoon/APACHE/spark/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala:71: type mismatch;
 found   : org.apache.spark.internal.config.OptionalConfigEntry[Boolean]
 required: String
[ERROR]       .set(IS_TESTING, false)
[ERROR]            ^
```

## How was this patch tested?

Pass the Jenkins K8S Integration test or Manual.

Closes apache#23505 from dongjoon-hyun/SPARK-26491.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants