-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-26491][K8S][FOLLOWUP] Fix compile failure #23505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #101007 has finished for PR 23505 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Thank you for review and approval, @felixcheung . |
|
a late LGTM, thanks for teh fix @dongjoon-hyun ! |
|
Thanks, @mgaido91 . |
|
I don't see this PR merged into master. My integration tests are still failing |
|
@ifilonenko . |
|
That's odd I am looking at master and see: |
|
Another commit breaks it again. I'll make a follow up for SPARK-26482. |
## What changes were proposed in this pull request? This fixes the compilation error. ``` $ cd resource-managers/kubernetes/integration-tests $ mvn test-compile [ERROR] /Users/dongjoon/APACHE/spark/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesTestComponents.scala:71: type mismatch; found : org.apache.spark.internal.config.OptionalConfigEntry[Boolean] required: String [ERROR] .set(IS_TESTING, false) [ERROR] ^ ``` ## How was this patch tested? Pass the Jenkins K8S Integration test or Manual. Closes apache#23505 from dongjoon-hyun/SPARK-26491. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
This fixes the compilation error.
How was this patch tested?
Pass the Jenkins K8S Integration test or Manual.