Skip to content

[SPARK-19712][SQL] Pushing Left Semi and Left Anti joins through Project, Aggregate, Window, Union etc. #23750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dilipbiswal wants to merge 12 commits into from
Closed

[SPARK-19712][SQL] Pushing Left Semi and Left Anti joins through Project, Aggregate, Window, Union etc. #23750

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ae5f6ee
[SPARK-19712] Pushing down Left Semi and Left Anti joins
dilipbiswal Feb 9, 2019
488eda8
Code review
dilipbiswal Feb 16, 2019
ea76e29
Code review
dilipbiswal Feb 18, 2019
43e9eef
Code review
dilipbiswal Feb 19, 2019
744355c
Code review
dilipbiswal Feb 20, 2019
0fa7950
minor
dilipbiswal Feb 20, 2019
4a11ad4
Don't pushdown in presence of scalar subqueries inside aggregate expr…
dilipbiswal Feb 20, 2019
fa41b44
Code review
dilipbiswal Mar 1, 2019
76e7203
review
dilipbiswal Mar 1, 2019
79579c8
fix1
dilipbiswal Mar 2, 2019
5ea6a4a
Code review
dilipbiswal Mar 4, 2019
68e7268
code reivew
dilipbiswal Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code review
  • Loading branch information
@dilipbiswal
dilipbiswal committed Mar 4, 2019
commit 5ea6a4a0717613c17c52039b64d871ec24a268e0
26 changes: 4 additions & 22 deletions ...rc/test/scala/org/apache/spark/sql/catalyst/optimizer/LeftSemiAntiJoinPushDownSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,7 @@ class LeftSemiPushdownSuite extends PlanTest {
.join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd))

val optimized = Optimize.execute(originalQuery.analyze)
val correctAnswer = testRelation
.select(Rand('a), 'b, 'c)
.join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd))
.analyze

comparePlans(optimized, correctAnswer)
comparePlans(optimized, originalQuery.analyze)
}

test("Project: LeftSemiAnti join non correlated scalar subq") {
Expand All @@ -96,12 +91,7 @@ class LeftSemiPushdownSuite extends PlanTest {
.join(testRelation1, joinType = LeftSemi, condition = Some('sum === 'd))

val optimized = Optimize.execute(originalQuery.analyze)
val correctAnswer = testRelation
.select(subqExpr.as("sum"))
.join(testRelation1, joinType = LeftSemi, condition = Some('sum === 'd))
.analyze

comparePlans(optimized, correctAnswer)
comparePlans(optimized, originalQuery.analyze)
}

test("Aggregate: LeftSemiAnti join pushdown") {
Expand All @@ -124,12 +114,7 @@ class LeftSemiPushdownSuite extends PlanTest {
.join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd))

val optimized = Optimize.execute(originalQuery.analyze)
val correctAnswer = testRelation
.groupBy('b)('b, Rand(10).as('c))
.join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd))
.analyze

comparePlans(optimized, correctAnswer)
comparePlans(optimized, originalQuery.analyze)
}

test("Aggregate: LeftSemiAnti join partial pushdown") {
Expand Down Expand Up @@ -235,7 +220,6 @@ class LeftSemiPushdownSuite extends PlanTest {
.join(testRelation2, joinType = LeftSemi, condition = Some('a === 'x))

val optimized = Optimize.execute(originalQuery.analyze)

comparePlans(optimized, originalQuery.analyze)
}

Expand Down Expand Up @@ -292,8 +276,6 @@ class LeftSemiPushdownSuite extends PlanTest {
.join(testRelation1, joinType = LeftSemi, condition = Some('b === 'd && 'd === 'out_col))

val optimized = Optimize.execute(originalQuery.analyze)
val correctAnswer = originalQuery.analyze

comparePlans(optimized, correctAnswer)
comparePlans(optimized, originalQuery.analyze)
}
}