-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-26329][CORE] Faster polling of executor memory metrics. #23767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9f5b195
[SPARK-26329][CORE] Faster polling of executor memory metrics.
wypoon 03e41a8
[SPARK-26329][CORE] Fix test compilation error in sql.
wypoon 7f6bd74
[SPARK-26329][CORE] Fix Mima issues.
wypoon 7397897
[SPARK-26329][CORE] Fix possible NPE.
wypoon e1aeafc
[SPARK-26329][CORE] Fix JsonProtocolSuite post-rebase to account for …
wypoon 75ba39d
[SPARK-26329][CORE] Extract polling logic into a separate class.
wypoon ea2ff0d
[SPARK-26329][CORE] On task failure, send executor metrics in the Tas…
wypoon 0cbfc04
[SPARK-26329][CORE] Unit tests for sending executor metrics in TaskRe…
wypoon 8cb30a8
[SPARK-26329][CORE] Add driver updates to test for executor metrics a…
wypoon 077abb0
[SPARK-26329][CORE] Add SparkListenerTaskEnd events to test for execu…
wypoon 7a3c90d
[SPARK-26329][CORE] Address feedback from irashid.
wypoon 3ed583a
[SPARK-26329][CORE] Fix ExecutorSuite failures.
wypoon 0a4828a
[SPARK-26329][CORE] Delete a comment on irashid's suggestion.
wypoon 9530b75
[SPARK-26329][CORE] Change executorUpdates to be a scala.collection.m…
wypoon 38a397c
[SPARK-26329][CORE] Update HistoryServerSuite.
wypoon e062e60
[SPARK-26329][CORE] Get executor updates and reset the peaks in a sin…
wypoon 20b4b7e
[SPARK-26329][CORE] Test fixes after rebase on master.
wypoon b898ad2
[SPARK-26329][CORE] Adopt some suggestions from attilapiros.
wypoon fbb55bf
[SPARK-26329][CORE] Address feedback from Imran Rashid.
wypoon 99addf1
[SPARK-26329][CORE] Make TCMP case class private.
wypoon 7331b27
[SPARK-26329][CORE] Fix a test post-rebase.
wypoon 7556d6a
[SPARK-26329][CORE] Update a doc comment based on feedback from Imran…
wypoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[SPARK-26329][CORE] Add driver updates to test for executor metrics a…
…ggregation. Add an internal check within the test showing how the expected aggregated metrics are calculated. This documents how the expected values are arrived at.
- Loading branch information
commit 8cb30a876151a7a6c155c2e3ba2fe09f6dfb3984
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is becoming pretty impossible to reason about . its not really your fault, its taking something that was probably a bit too complex in the first place, and adding to it. anyway I will think if there is a better way we can organize this test, don't worry about it for now (unless you have a better idea ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it is virtually impossible to reason about the arrays of numbers.
However, that is why I introduced:
and the internal check that the calculated peaks match the peak values that I check against at the end.
When you look at what events are sent, you can match them with the above definitions, and you can reason about the correctness of the metric aggregation.