Skip to content

[SPARK-27065][CORE] avoid more than one active task set managers for a stage #23927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 6 commits into from
Closed

[SPARK-27065][CORE] avoid more than one active task set managers for a stage #23927

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
424a3c8
avoid more than one active task set managers for a stage
cloud-fan Mar 1, 2019
53c6ed8
fix a mistake
cloud-fan Mar 2, 2019
f94809d
fix tests
cloud-fan Mar 4, 2019
0ca733d
add test
cloud-fan Mar 5, 2019
07d7de9
fix typo
cloud-fan Mar 5, 2019
58f646e
revert adding volatile
cloud-fan Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@cloud-fan
cloud-fan committed Mar 4, 2019
commit f94809df47668600c2044bce3ecc2e1650b6e192
20 changes: 0 additions & 20 deletions core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,30 +201,10 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
// Even if one of the task sets has not-serializable tasks, the other task set should
// still be processed without error
taskScheduler.submitTasks(FakeTask.createTaskSet(1))
taskScheduler.submitTasks(taskSet)
Copy link
Contributor Author

@cloud-fan cloud-fan Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't have 2 active task set managers at the same time.

Copy link
Contributor

@jiangxb1987 jiangxb1987 Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we shall just give it another stageId ?

taskDescriptions = taskScheduler.resourceOffers(multiCoreWorkerOffers).flatten
assert(taskDescriptions.map(_.executorId) === Seq("executor0"))
}

test("refuse to schedule concurrent attempts for the same stage (SPARK-8103)") {
Copy link
Contributor Author

@cloud-fan cloud-fan Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part of code is reverted in this PR, so remove the test as well

Copy link
Contributor

@jiangxb1987 jiangxb1987 Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but do we also want to add a test case to ensure the new behavior will not break ?

val taskScheduler = setupScheduler()
val attempt1 = FakeTask.createTaskSet(1, 0)
val attempt2 = FakeTask.createTaskSet(1, 1)
taskScheduler.submitTasks(attempt1)
intercept[IllegalStateException] { taskScheduler.submitTasks(attempt2) }

// OK to submit multiple if previous attempts are all zombie
taskScheduler.taskSetManagerForAttempt(attempt1.stageId, attempt1.stageAttemptId)
.get.isZombie = true
taskScheduler.submitTasks(attempt2)
val attempt3 = FakeTask.createTaskSet(1, 2)
intercept[IllegalStateException] { taskScheduler.submitTasks(attempt3) }
taskScheduler.taskSetManagerForAttempt(attempt2.stageId, attempt2.stageAttemptId)
.get.isZombie = true
taskScheduler.submitTasks(attempt3)
assert(!failedTaskSet)
}

test("don't schedule more tasks after a taskset is zombie") {
val taskScheduler = setupScheduler()

Expand Down