Skip to content

[SPARK-27061][K8S] Expose Driver UI port on driver service to access … #23990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chandulal wants to merge 5 commits into from
Closed

[SPARK-27061][K8S] Expose Driver UI port on driver service to access … #23990

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09d6611
[SPARK-27061][K8S] Expose Driver UI port on driver service to access …
Mar 6, 2019
0d8e4fc
[SPARK-27061][K8S] Use default value of UI_PORT
Mar 7, 2019
ffc2e2f
[SPARK-27061][K8S] Use UI_PORT default value
Mar 8, 2019
b7c4e66
[SPARK-27061][K8S] Use get method of sparkconf to get UI Port
Mar 8, 2019
6945580
[SPARK-27061][K8S] Remove unused imports
Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[SPARK-27061][K8S] Use UI_PORT default value
  • Loading branch information
chandulal.kavar committed Mar 8, 2019
commit ffc2e2fd52b05fc589083185a5faab4bc2957794
3 changes: 0 additions & 3 deletions resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
*/
package org.apache.spark.deploy.k8s

import org.apache.spark.internal.config.UI._

private[spark] object Constants {

// Labels
Expand Down Expand Up @@ -47,7 +45,6 @@ private[spark] object Constants {
// Default and fixed ports
val DEFAULT_DRIVER_PORT = 7078
val DEFAULT_BLOCKMANAGER_PORT = 7079
val DEFAULT_UI_PORT = UI_PORT.defaultValue.get
val DRIVER_PORT_NAME = "driver-rpc-port"
val BLOCK_MANAGER_PORT_NAME = "blockmanager"
val UI_PORT_NAME = "spark-ui"
Expand Down
2 changes: 1 addition & 1 deletion ...s/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverServiceFeatureStep.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ private[spark] class DriverServiceFeatureStep(
private val driverBlockManagerPort = kubernetesConf.sparkConf.getInt(
config.DRIVER_BLOCK_MANAGER_PORT.key, DEFAULT_BLOCKMANAGER_PORT)
private val driverUIPort = kubernetesConf.sparkConf.getInt(
UI_PORT.key, DEFAULT_UI_PORT)
UI_PORT.key, UI_PORT.defaultValue.get)

override def configurePod(pod: SparkPod): SparkPod = pod

Expand Down
7 changes: 4 additions & 3 deletions ...e/src/test/scala/org/apache/spark/deploy/k8s/features/DriverServiceFeatureStepSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import org.apache.spark.deploy.k8s.Config._
import org.apache.spark.deploy.k8s.Constants._
import org.apache.spark.deploy.k8s.submit.JavaMainAppResource
import org.apache.spark.internal.config._
import org.apache.spark.internal.config.UI._
import org.apache.spark.util.ManualClock

class DriverServiceFeatureStepSuite extends SparkFunSuite {
Expand All @@ -42,7 +43,7 @@ class DriverServiceFeatureStepSuite extends SparkFunSuite {
val sparkConf = new SparkConf(false)
.set(DRIVER_PORT, 9000)
.set(DRIVER_BLOCK_MANAGER_PORT, 8080)
.set(UI_PORT_NAME, "4040")
.set(UI_PORT, 4080)
val kconf = KubernetesTestConf.createDriverConf(
sparkConf = sparkConf,
labels = DRIVER_LABELS)
Expand All @@ -57,7 +58,7 @@ class DriverServiceFeatureStepSuite extends SparkFunSuite {
verifyService(
9000,
8080,
4040,
4080,
s"${kconf.resourceNamePrefix}${DriverServiceFeatureStep.DRIVER_SVC_POSTFIX}",
driverService)
}
Expand Down Expand Up @@ -87,7 +88,7 @@ class DriverServiceFeatureStepSuite extends SparkFunSuite {
verifyService(
DEFAULT_DRIVER_PORT,
DEFAULT_BLOCKMANAGER_PORT,
DEFAULT_UI_PORT,
UI_PORT.defaultValue.get,
s"${kconf.resourceNamePrefix}${DriverServiceFeatureStep.DRIVER_SVC_POSTFIX}",
resolvedService)
val additionalProps = configurationStep.getAdditionalPodSystemProperties()
Expand Down