Skip to content

[SPARK-27198][core] Heartbeat interval mismatch in driver and executor #24140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajithme wants to merge 10 commits into from
Closed

[SPARK-27198][core] Heartbeat interval mismatch in driver and executor #24140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
12b53ee
fix interval to be uniform when no unit is mentioned
ajithme Mar 19, 2019
5755b31
handle magic number as per review comment
ajithme Mar 19, 2019
bc39695
handle non-unit time as millisecond
ajithme Mar 21, 2019
fb9ea5c
standardize heartbeat interval config
ajithme Mar 22, 2019
76570b7
update
ajithme Mar 22, 2019
596c9b2
update
ajithme Mar 24, 2019
c62330a
update
ajithme Mar 24, 2019
9941e93
update
ajithme Mar 24, 2019
39d9b59
updated
ajithme Mar 24, 2019
6c17bf8
update
ajithme Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@ajithme
ajithme committed Mar 22, 2019
commit 76570b7f1dad8cb1e5f58dd1718a21e770148e53
3 changes: 1 addition & 2 deletions core/src/main/scala/org/apache/spark/SparkConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
package org.apache.spark

import java.util.{Map => JMap}
import java.util.concurrent.{ConcurrentHashMap, TimeUnit}
import java.util.concurrent.ConcurrentHashMap

import scala.collection.JavaConverters._
import scala.collection.mutable.LinkedHashSet
Expand All @@ -29,7 +29,6 @@ import org.apache.avro.{Schema, SchemaNormalization}
import org.apache.spark.deploy.history.config._
import org.apache.spark.internal.Logging
import org.apache.spark.internal.config._
import org.apache.spark.network.util.JavaUtils
import org.apache.spark.serializer.KryoSerializer
import org.apache.spark.util.Utils

Expand Down
1 change: 0 additions & 1 deletion core/src/main/scala/org/apache/spark/executor/Executor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,6 @@ private[spark] class Executor(

val message = Heartbeat(executorId, accumUpdates.toArray, env.blockManager.blockManagerId)
try {

val response = heartbeatReceiverRef.askSync[HeartbeatResponse](
message, new RpcTimeout(heartbeatInterval.millis.toSeconds.seconds,
EXECUTOR_HEARTBEAT_INTERVAL.key))
Expand Down