Skip to content

[SPARK-27240][PYTHON] Use pandas DataFrame for struct type argument in Scalar Pandas UDF. #24177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 3 commits into from
Closed

[SPARK-27240][PYTHON] Use pandas DataFrame for struct type argument in Scalar Pandas UDF. #24177

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d503aa2
Use pandas DataFrame for struct type argument in Scalar Pandas UDF.
ueshin Mar 22, 2019
f8b3404
Add a comment.
ueshin Mar 22, 2019
4309d46
Use `arrow_column.flatten()`.
ueshin Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a comment.
  • Loading branch information
@ueshin
ueshin committed Mar 22, 2019
commit f8b34041fe16f64aac2baaf14e32925635984ff8
2 changes: 2 additions & 0 deletions python/pyspark/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@ def read_udfs(pickleSer, infile, eval_type):
"spark.sql.legacy.execution.pandas.groupedMap.assignColumnsByName", "true")\
.lower() == "true"

# Scalar Pandas UDF handles struct type arguments as pandas DataFrames instead of
# pandas Series. See SPARK-27240.
df_for_struct = eval_type == PythonEvalType.SQL_SCALAR_PANDAS_UDF
Copy link
Member

@viirya viirya Mar 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems hard to tell why when eval_type is PythonEvalType.SQL_SCALAR_PANDAS_UDF, then df_for_struct should be true. Maybe a well explained comment here is better.

Copy link
Member Author

@ueshin ueshin Mar 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will add a comment.

ser = ArrowStreamPandasUDFSerializer(timezone, safecheck, assign_cols_by_name,
df_for_struct)
Expand Down