Skip to content

[SPARK-27653][SQL] Add max_by() and min_by() SQL aggregate functions #24557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 6 commits into from
Closed

[SPARK-27653][SQL] Add max_by() and min_by() SQL aggregate functions #24557

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5c7e3c5
Add max_by.
viirya May 8, 2019
79f1015
Add min_by.
viirya May 9, 2019
798f0fa
Add test.
viirya May 9, 2019
26b5a32
Using DSL.
viirya May 11, 2019
dd1d9de
Address comments.
viirya May 13, 2019
05f1767
Renaming variables.
viirya May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test.
  • Loading branch information
@viirya
viirya committed May 9, 2019
commit 798f0fa1bf8b51819a34a36239fa3e29db3ff53b
26 changes: 26 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,6 +813,19 @@ class DataFrameAggregateSuite extends QueryTest with SharedSQLContext {
Row(null) :: Nil
)

// structs as ordering value.
checkAnswer(
sql("select max_by(x, y) FROM VALUES (('a', (10, 20))), (('b', (10, 50))), " +
"(('c', (10, 60))) AS tab(x, y)"),
Row("c") :: Nil
)

checkAnswer(
sql("select max_by(x, y) FROM VALUES (('a', (10, 20))), (('b', (10, 50))), " +
"(('c', null)) AS tab(x, y)"),
Row("b") :: Nil
)

withTempView("tempView") {
val dfWithMap = Seq((0, "a"), (1, "b"), (2, "c"))
.toDF("x", "y")
Expand Down Expand Up @@ -856,6 +869,19 @@ class DataFrameAggregateSuite extends QueryTest with SharedSQLContext {
Row(null) :: Nil
)

// structs as ordering value.
checkAnswer(
sql("select min_by(x, y) FROM VALUES (('a', (10, 20))), (('b', (10, 50))), " +
"(('c', (10, 60))) AS tab(x, y)"),
Row("a") :: Nil
)

checkAnswer(
sql("select min_by(x, y) FROM VALUES (('a', null)), (('b', (10, 50))), " +
"(('c', (10, 60))) AS tab(x, y)"),
Row("b") :: Nil
)

withTempView("tempView") {
val dfWithMap = Seq((0, "a"), (1, "b"), (2, "c"))
.toDF("x", "y")
Expand Down