Skip to content

[SPARK-23160][SQL][TEST] Port window.sql #24881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DylanGuedes wants to merge 25 commits into from
Closed

[SPARK-23160][SQL][TEST] Port window.sql #24881

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
ecde439
Start the port of window.sql tests from Postgrsql
DylanGuedes Jun 16, 2019
7c19413
Adds new references to SQL jiras
DylanGuedes Jun 16, 2019
1f53dc9
remove unprecise comment
DylanGuedes Jun 16, 2019
4f08ee9
adds new reference to jira
DylanGuedes Jun 16, 2019
f2895ff
Adds new comments about queries. Update others SQL golden files
DylanGuedes Jun 17, 2019
68695c0
update golden files
DylanGuedes Jun 20, 2019
0a1f587
remove untruncated queries results
DylanGuedes Jul 5, 2019
331a8ac
update sqlwindow tests
DylanGuedes Jul 17, 2019
11e2373
remove additiona 'e' char
DylanGuedes Jul 17, 2019
e8ace71
fix
dongjoon-hyun Jul 17, 2019
e1ff740
update with new jiras
DylanGuedes Jul 23, 2019
d149949
adds pointer to new jiras
DylanGuedes Jul 24, 2019
7ab9947
commented out calls to EXPLAIN clause
DylanGuedes Jul 25, 2019
94bb6e3
update with JIRAs
DylanGuedes Jul 29, 2019
4ccbe50
adds drop table numerics
DylanGuedes Jul 29, 2019
76d2820
update golden file
DylanGuedes Jul 29, 2019
bea5ba6
temporarily turns off ansi
DylanGuedes Jul 30, 2019
d7b1f77
exchange jira numbers
DylanGuedes Jul 30, 2019
9150d0d
remove query
DylanGuedes Jul 30, 2019
25181fd
uncomment wrong queries
DylanGuedes Jul 31, 2019
e776cc3
update with casting types
DylanGuedes Aug 1, 2019
ef23020
adds new jira
DylanGuedes Aug 2, 2019
60c626a
adds groups jira
DylanGuedes Aug 7, 2019
826708d
update new PRs
DylanGuedes Aug 14, 2019
80f2915
adds comment for some queries
DylanGuedes Sep 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
temporarily turns off ansi 
Signed-off-by: DylanGuedes <[email protected]>
  • Loading branch information
@DylanGuedes
DylanGuedes committed Aug 14, 2019
commit bea5ba6e577a47f4c57b845de8b54507142e2f0b
22 changes: 12 additions & 10 deletions sql/core/src/test/resources/sql-tests/inputs/pgSQL/window.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,16 @@ SELECT count(*) OVER (PARTITION BY four) FROM (SELECT * FROM tenk1 WHERE FALSE)s
SELECT sum(salary) OVER w, rank() OVER w FROM empsalary WINDOW w AS (PARTITION BY depname ORDER BY salary DESC);

-- strict aggs
-- no viable alternative at input 'year'
-- SELECT empno, depname, salary, bonus, depadj, MIN(bonus) OVER (ORDER BY empno), MAX(depadj) OVER () FROM(
-- SELECT *,
-- CASE WHEN enroll_date < '2008-01-01' THEN 2008 - extract(year FROM enroll_date) END * 500 AS bonus,
-- CASE WHEN
-- AVG(salary) OVER (PARTITION BY depname) < salary
-- THEN 200 END AS depadj FROM empsalary
-- )s;
-- Temporarily turns off the ANSI mode because of compatibility issues between keywords
SET spark.sql.parser.ansi.enabled=false;
SELECT empno, depname, salary, bonus, depadj, MIN(bonus) OVER (ORDER BY empno), MAX(depadj) OVER () FROM(
SELECT *,
CASE WHEN enroll_date < '2008-01-01' THEN 2008 - extract(year FROM enroll_date) END * 500 AS bonus,
CASE WHEN
AVG(salary) OVER (PARTITION BY depname) < salary
THEN 200 END AS depadj FROM empsalary
)s;
SET spark.sql.parser.ansi.enabled=true;

create temporary view int4_tbl as select * from values
(0),
Expand Down Expand Up @@ -932,8 +934,7 @@ from t1 where f1 = f2;
SELECT rank() OVER (ORDER BY length('abc'));

-- can't order by another window function
-- [SPARK-28086] Adds `random()` to Spark
-- SELECT rank() OVER (ORDER BY rank() OVER (ORDER BY random()));
SELECT rank() OVER (ORDER BY rank() OVER (ORDER BY random()));
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur, please file another JIRA issue since the behavior is different.

postgres=# SELECT rank() OVER (ORDER BY rank() OVER (ORDER BY random()));
ERROR:  window functions are not allowed in window definitions
LINE 1: SELECT rank() OVER (ORDER BY rank() OVER (ORDER BY random())...

spark-sql> SELECT rank() OVER (ORDER BY rank() OVER (ORDER BY random()));
1


-- some other errors
select * from
Expand Down Expand Up @@ -1165,3 +1166,4 @@ SELECT i,SUM(v) OVER (ORDER BY i ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING)
drop table numerics;
drop table t1;
drop view int4_tbl;
drop table datetimes;
Loading