Skip to content

[SPARK-28341][SQL] create a public API for V2SessionCatalog #25104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 10 commits into from
Closed

[SPARK-28341][SQL] create a public API for V2SessionCatalog #25104

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ffc391b
create a public API for v2 session catalog
cloud-fan Aug 22, 2019
efe6f9c
address comments
cloud-fan Aug 30, 2019
a19943f
fix test
cloud-fan Aug 30, 2019
1d9f155
address comments
cloud-fan Sep 5, 2019
155c37f
add Experimental
cloud-fan Sep 5, 2019
75e2ca7
Merge remote-tracking branch 'origin/master' into session-catalog
cloud-fan Sep 5, 2019
f89f25a
fix tests
cloud-fan Sep 5, 2019
494e031
fix test
cloud-fan Sep 5, 2019
8240062
Merge remote-tracking branch 'origin/master' into session-catalog
cloud-fan Sep 6, 2019
05db860
add error log
cloud-fan Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
  • Loading branch information
@cloud-fan
cloud-fan committed Sep 5, 2019
commit a19943f4b1df437f4725f968853b21962be126e0
8 changes: 7 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/CatalogManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,13 @@ class CatalogManager(conf: SQLConf, sessionCatalog: TableCatalog) extends Loggin
private val catalogs = mutable.HashMap.empty[String, CatalogPlugin]

def catalog(name: String): CatalogPlugin = synchronized {
catalogs.getOrElseUpdate(name, Catalogs.load(name, conf))
if (name.equalsIgnoreCase(CatalogManager.SESSION_CATALOG_NAME)) {
v2SessionCatalog.getOrElse {
throw new IllegalStateException("v2 session catalog not available")
Copy link
Contributor

@brkyvz brkyvz Sep 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not sessionCatalog?

}
} else {
catalogs.getOrElseUpdate(name, Catalogs.load(name, conf))
}
}

def defaultCatalog: Option[CatalogPlugin] = {
Expand Down