Skip to content

[SPARK-28647][WEBUI] Recover additional metric feature and remove additional-metrics.js #25374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 2 commits into from
Closed

[SPARK-28647][WEBUI] Recover additional metric feature and remove additional-metrics.js #25374

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8b3328
Remove additional-metrics.js
sarutak Aug 7, 2019
b5be743
Add checkbox to ExecutorsPage for optional metrics
sarutak Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove additional-metrics.js
  • Loading branch information
@sarutak
sarutak committed Aug 7, 2019
commit a8b3328f44db2355ba2655f74abfffd2ba87155c
90 changes: 0 additions & 90 deletions core/src/main/resources/org/apache/spark/ui/static/additional-metrics.js
View file
Open in desktop

This file was deleted.

10 changes: 3 additions & 7 deletions core/src/main/resources/org/apache/spark/ui/static/webui.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,11 @@ pre {
display: none;
}

span.expand-additional-metrics, span.expand-dag-viz, span.collapse-table {
span.expand-dag-viz, span.collapse-table {
cursor: pointer;
}

span.additional-metric-title {
cursor: pointer;
}

.additional-metrics.collapsed, .collapsible-table.collapsed {
.collapsible-table.collapsed {
display: none;
}

Expand Down Expand Up @@ -361,4 +357,4 @@ a.expandbutton {

#active-executors-table th:first-child {
border-left: 1px solid #dddddd;
}
}
1 change: 0 additions & 1 deletion core/src/main/scala/org/apache/spark/ui/UIUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ private[spark] object UIUtils extends Logging {
<script src={prependBaseUri(request, "/static/bootstrap-tooltip.js")}></script>
<script src={prependBaseUri(request, "/static/initialize-tooltips.js")}></script>
<script src={prependBaseUri(request, "/static/table.js")}></script>
<script src={prependBaseUri(request, "/static/additional-metrics.js")}></script>
<script src={prependBaseUri(request, "/static/timeline-view.js")}></script>
<script src={prependBaseUri(request, "/static/log-view.js")}></script>
<script src={prependBaseUri(request, "/static/webui.js")}></script>
Expand Down