Skip to content

[SPARK-28784][SS] Use CheckpointFileManager in StreamExecution/StreamingQueryManager for checkpoint dirs #25514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shrutig wants to merge 4 commits into from
Closed

[SPARK-28784][SS] Use CheckpointFileManager in StreamExecution/StreamingQueryManager for checkpoint dirs #25514

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
97bcf5b
Updated StreamExecution and StreamingQueryManager to utilize Checkpoi…
shrutig Aug 20, 2019
9a92b5e
Updated DataStreamReaderWriterSuite tests
shrutig Aug 21, 2019
626992e
Merge branch 'master' of github.pie.apple.com:pie/apache-spark into S…
shrutig Aug 22, 2019
73ff29b
updated StreamSuite, StreamingQuerySuite, DataStreamReaderWriterSuite…
shrutig Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated DataStreamReaderWriterSuite tests
  • Loading branch information
@shrutig
shrutig committed Aug 21, 2019
commit 9a92b5e8a3606e97286c36b3e5f8d364e9943d13
16 changes: 9 additions & 7 deletions ...core/src/test/scala/org/apache/spark/sql/streaming/test/DataStreamReaderWriterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,10 +633,11 @@ class DataStreamReaderWriterSuite extends StreamTest with BeforeAndAfter {
query.processAllAvailable()
val checkpointDir = new Path(
query.asInstanceOf[StreamingQueryWrapper].streamingQuery.resolvedCheckpointRoot)
val fs = checkpointDir.getFileSystem(spark.sessionState.newHadoopConf())
assert(fs.exists(checkpointDir))
val checkpointFileManager = CheckpointFileManager.create(checkpointDir,
spark.sessionState.newHadoopConf())
assert(checkpointFileManager.exists(checkpointDir))
query.stop()
assert(!fs.exists(checkpointDir))
assert(!checkpointFileManager.exists(checkpointDir))
}

testQuietly("temp checkpoint dir should not be deleted if a query is stopped with an error") {
Expand All @@ -656,16 +657,17 @@ class DataStreamReaderWriterSuite extends StreamTest with BeforeAndAfter {
val query = input.toDS.map(_ / 0).writeStream.format("console").start()
val checkpointDir = new Path(
query.asInstanceOf[StreamingQueryWrapper].streamingQuery.resolvedCheckpointRoot)
val fs = checkpointDir.getFileSystem(spark.sessionState.newHadoopConf())
assert(fs.exists(checkpointDir))
val checkpointFileManager = CheckpointFileManager.create(checkpointDir,
spark.sessionState.newHadoopConf())
assert(checkpointFileManager.exists(checkpointDir))
input.addData(1)
intercept[StreamingQueryException] {
query.awaitTermination()
}
if (!checkpointMustBeDeleted) {
assert(fs.exists(checkpointDir))
assert(checkpointFileManager.exists(checkpointDir))
} else {
assert(!fs.exists(checkpointDir))
assert(!checkpointFileManager.exists(checkpointDir))
}
}

Expand Down