Skip to content

[SPARK-28973][SQL] Add TimeType and support java.time.LocalTime as its external type. #25678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 18 commits into from
Closed

[SPARK-28973][SQL] Add TimeType and support java.time.LocalTime as its external type. #25678

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4e03050
Add TimeType
MaxGekk Sep 3, 2019
d3b5764
Add the MakeTime expression
MaxGekk Sep 3, 2019
50a7b41
Add tests to DateExpressionsSuite
MaxGekk Sep 3, 2019
e41f52c
Converters for LocalTime
MaxGekk Sep 3, 2019
baa632b
Reuse localTimeToMicros in MakeTime
MaxGekk Sep 3, 2019
cee85e1
Support Row encoding
MaxGekk Sep 3, 2019
51d48d5
Support TimeType as Literal
MaxGekk Sep 3, 2019
61329e0
Register make_time
MaxGekk Sep 3, 2019
a2a5d9d
Implicit encoder for LocalTime
MaxGekk Sep 4, 2019
b67f270
Construct literals from java.time.LocalTime
MaxGekk Sep 4, 2019
1d68f58
Test make_time
MaxGekk Sep 4, 2019
ef53768
Revert "Test make_time"
MaxGekk Sep 4, 2019
a1ba921
Revert "Register make_time"
MaxGekk Sep 4, 2019
3324444
Revert "Reuse localTimeToMicros in MakeTime"
MaxGekk Sep 4, 2019
0202151
Revert "Add tests to DateExpressionsSuite"
MaxGekk Sep 4, 2019
50eaeb0
Revert "Add the MakeTime expression"
MaxGekk Sep 4, 2019
a8adade
Fix a typo
MaxGekk Sep 4, 2019
bd6b976
Mark TimeType unstable
MaxGekk Sep 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Reuse localTimeToMicros in MakeTime" 
This reverts commit baa632b.
  • Loading branch information
@MaxGekk
MaxGekk committed Sep 4, 2019
commit 33244442390fa77a9ced4a85fe7e4fb425abb29c
4 changes: 2 additions & 2 deletions ...talyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1950,7 +1950,7 @@ case class MakeTime(hour: Expression, min: Expression, sec: Expression)
} else {
LocalTime.of(hour, min, seconds, nanos)
}
localTimeToMicros(localTime)
localTime.getLong(MICRO_OF_DAY)
} catch {
case _: DateTimeException => null
}
Expand All @@ -1977,7 +1977,7 @@ case class MakeTime(hour: Expression, min: Expression, sec: Expression)
} else {
localTime = java.time.LocalTime.of($hour, $min, seconds, nanos);
}
${ev.value} = $dtu.localTimeToMicros(localTime);
localTime.getLong(java.time.temporal.ChronoField.MICRO_OF_DAY);
} catch (java.time.DateTimeException e) {
${ev.isNull} = true;
}"""
Expand Down