Skip to content

[SPARK-28989][SQL] Introduce ANSI SQL Dialect #25693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 7 commits into from
+86 −109
Closed

[SPARK-28989][SQL] Introduce ANSI SQL Dialect #25693

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
87f4ed0
Add spark.sql.ansi.enabled
gengliangwang Sep 5, 2019
e41fca3
update comments
gengliangwang Sep 5, 2019
63643df
fix sql files
gengliangwang Sep 5, 2019
da014fb
update sql/sql.out
gengliangwang Sep 13, 2019
7c32fee
update
gengliangwang Sep 18, 2019
342ce1c
revise
gengliangwang Sep 18, 2019
3a07455
a typo
gatorsmile Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix sql files
  • Loading branch information
@gengliangwang
gengliangwang committed Sep 18, 2019
commit 63643dfd454a52396567afb6dc577905f7e3ae15
4 changes: 2 additions & 2 deletions sql/core/src/test/resources/sql-tests/inputs/ansi/interval.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
-- Turns on ANSI mode
SET spark.sql.parser.ansi.enabled=true;
SET spark.sql.ansi.enabled=true;

select
'1' second,
Expand Down Expand Up @@ -185,4 +185,4 @@ select date '2012-01-01' + interval (a + 1) day from t;
select date '2012-01-01' + (a + 1) day from t;

-- Turns off ANSI mode
SET spark.sql.parser.ansi.enabled=false;
SET spark.sql.ansi.enabled=false;
5 changes: 4 additions & 1 deletion sql/core/src/test/resources/sql-tests/inputs/decimalArithmeticOperations.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ select 123456789123456789.1234567890 * 1.123456789123456789;
select 12345678912345.123456789123 / 0.000000012345678;

-- throw an exception instead of returning NULL, according to SQL ANSI 2011
set spark.sql.decimalOperations.nullOnOverflow=false;
set spark.sql.parser.ansi.enabled=true;

-- test operations between decimals and constants
select id, a*10, b/10 from decimals_test order by id;
Expand All @@ -108,3 +108,6 @@ select 123456789123456789.1234567890 * 1.123456789123456789;
select 12345678912345.123456789123 / 0.000000012345678;

drop table decimals_test;

-- Turns off ANSI mode
set spark.sql.parser.ansi.enabled=false;
6 changes: 3 additions & 3 deletions sql/core/src/test/resources/sql-tests/inputs/pgSQL/text.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ select concat_ws('',10,20,null,30);
select concat_ws(NULL,10,20,null,30) is null;
select reverse('abcde');
-- [SPARK-28036] Built-in udf left/right has inconsistent behavior
-- [SPARK-28479] Parser error when enabling ANSI mode
set spark.sql.parser.ansi.enabled=false;
-- [SPARK-28479][SPARK-28989] Parser error when enabling ANSI mode
set spark.sql.ansi.enabled=false;
select i, left('ahoj', i), right('ahoj', i) from range(-5, 6) t(i) order by i;
set spark.sql.parser.ansi.enabled=true;
set spark.sql.ansi.enabled=true;
-- [SPARK-28037] Add built-in String Functions: quote_literal
-- select quote_literal('');
-- select quote_literal('abc''');
Expand Down