Skip to content

[SPARK-28997][SQL] Add spark.sql.dialect #25697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 10 commits into from
Closed

[SPARK-28997][SQL] Add spark.sql.dialect #25697

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e7f281
dialect
gengliangwang Sep 23, 2019
094d58e
new package and expression
gengliangwang Sep 24, 2019
9f14680
revise
gengliangwang Sep 24, 2019
5a69400
address comments
gengliangwang Sep 25, 2019
bb657e9
fix test failure
gengliangwang Sep 25, 2019
82a9e4d
revise
gengliangwang Sep 25, 2019
72a1539
add NullIntolerant trait
gengliangwang Sep 25, 2019
af97b99
address comments
gengliangwang Sep 25, 2019
b518114
address more comments
gengliangwang Sep 26, 2019
75aeda7
one more comment
gengliangwang Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
one more comment
  • Loading branch information
@gengliangwang
gengliangwang committed Sep 26, 2019
commit 75aeda757b10b8601cb386a53a87d888fc6556e1
8 changes: 5 additions & 3 deletions ...ala/org/apache/spark/sql/catalyst/expressions/postgreSQL/PostgreCastStringToBoolean.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ case class PostgreCastStringToBoolean(child: Expression)
}

override def nullSafeEval(input: Any): Any = {
val s = input.asInstanceOf[UTF8String]
val s = input.asInstanceOf[UTF8String].trim().toLowerCase()
if (StringUtils.isTrueString(s)) {
true
} else if (StringUtils.isFalseString(s)) {
Expand All @@ -51,14 +51,16 @@ case class PostgreCastStringToBoolean(child: Expression)
val stringUtils = inline"${StringUtils.getClass.getName.stripSuffix("$")}"
val eval = child.genCode(ctx)
val javaType = JavaCode.javaType(dataType)
val preprocessedString = ctx.freshName("preprocessedString")
val castCode =
code"""
boolean ${ev.isNull} = ${eval.isNull};
$javaType ${ev.value} = false;
if (!${eval.isNull}) {
if ($stringUtils.isTrueString(${eval.value})) {
UTF8String $preprocessedString = ${eval.value}.trim().toLowerCase();
if ($stringUtils.isTrueString($preprocessedString)) {
${ev.value} = true;
} else if ($stringUtils.isFalseString(${eval.value})) {
} else if ($stringUtils.isFalseString($preprocessedString)) {
${ev.value} = false;
} else {
${ev.isNull} = true;
Expand Down
4 changes: 2 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/postgreSQL/StringUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ object StringUtils {
private[this] val falseStrings =
Set("false", "fals", "fal", "fa", "f", "no", "n", "off", "of", "0").map(UTF8String.fromString)

def isTrueString(s: UTF8String): Boolean = trueStrings.contains(s.trim().toLowerCase())
def isTrueString(s: UTF8String): Boolean = trueStrings.contains(s)

def isFalseString(s: UTF8String): Boolean = falseStrings.contains(s.trim().toLowerCase())
def isFalseString(s: UTF8String): Boolean = falseStrings.contains(s)
}