-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29026][SQL] Improve error message in schemaFor in trait without companion object constructor
#25736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mickjermsurawong-stripe
wants to merge
9
commits into
apache:master
from
mickjermsurawong-stripe:SPARK-29026
Closed
[SPARK-29026][SQL] Improve error message in schemaFor in trait without companion object constructor
#25736
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ee24c7a
improve error message
mickjermsurawong-stripe c78cd01
improve string interpolation
mickjermsurawong-stripe 8c2fce7
check at companion object
mickjermsurawong-stripe 897f737
improve doc
mickjermsurawong-stripe 0f2c94e
improve error message format
mickjermsurawong-stripe 88de1e3
handle companion object without apply
mickjermsurawong-stripe 47a9da5
variable rename
mickjermsurawong-stripe 8ad3769
nested pattern match
mickjermsurawong-stripe 722a090
remove extra line
mickjermsurawong-stripe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ Scrolling up, an existing test is for
ScroogeLikeExamplewhere it checks that trait with companion object constructor works.