-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28292][SQL] Enable Injection of User-defined Hint #25746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #110428 has finished for PR 25746 at commit
|
|
This way will be more flexible. Thanks . |
|
LGTM |
|
Hi, @gatorsmile . Shall we remove |
|
Retest this please. |
|
Test build #110841 has finished for PR 25746 at commit
|
|
Test build #110842 has finished for PR 25746 at commit
|
|
We need to add a test case to ensure the other user-added hints can be added and recognized. |
|
Got it. Thank you for making this change, @gatorsmile ! |
|
Test build #111203 has finished for PR 25746 at commit
|
|
retest this please |
|
nit: |
|
Test build #111226 has finished for PR 25746 at commit
|
|
thanks, merging to master! |
What changes were proposed in this pull request?
Move the rule
RemoveAllHintsafter the batchResolution.Why are the changes needed?
User-defined hints can be resolved by the rules injected via
extendedResolutionRulesorpostHocResolutionRules.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a test case