Skip to content

[SPARK-28937][SPARK-28936][KUBERNETES] Reduce test flakyness #25765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
holdenk wants to merge 8 commits into from
Closed

[SPARK-28937][SPARK-28936][KUBERNETES] Reduce test flakyness #25765

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e9bf47f
Work on debugging the secrets test
holdenk Aug 28, 2019
805fe3a
Test pass (yay)
holdenk Aug 30, 2019
86f9e75
Add a listener in place of Thread.sleep for executing commands inside…
holdenk Aug 30, 2019
3ccddbf
Remove printlns from my debugging
holdenk Aug 31, 2019
916372c
Switch some constant uses of username/password to the object ref and …
holdenk Sep 4, 2019
16ba894
cammel fix
holdenk Sep 11, 2019
2ab68b5
Style fixes
holdenk Sep 11, 2019
de35d67
Add missing Locale import
holdenk Sep 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Work on debugging the secrets test
  • Loading branch information
@holdenk
holdenk committed Aug 31, 2019
commit e9bf47f635d91f0057835faf68470c15e2da5c06
41 changes: 29 additions & 12 deletions ...-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,19 +81,36 @@ private[spark] trait SecretsTestsSuite { k8sSuite: KubernetesSuite =>
}

private def checkSecrets(pod: Pod): Unit = {
Eventually.eventually(TIMEOUT, INTERVAL) {
implicit val podName: String = pod.getMetadata.getName
implicit val components: KubernetesTestComponents = kubernetesTestComponents
val env = Utils.executeCommand("env")
assert(env.toString.contains(ENV_SECRET_VALUE_1))
assert(env.toString.contains(ENV_SECRET_VALUE_2))
val fileUsernameContents = Utils
.executeCommand("cat", s"$SECRET_MOUNT_PATH/$ENV_SECRET_KEY_1")
val filePasswordContents = Utils
.executeCommand("cat", s"$SECRET_MOUNT_PATH/$ENV_SECRET_KEY_2")
assert(fileUsernameContents.toString.trim.equals(ENV_SECRET_VALUE_1))
assert(filePasswordContents.toString.trim.equals(ENV_SECRET_VALUE_2))
println("Checking secrets for " + pod)
// We do the env lookup in eventually, but since it shouldn't
// change after the pod is launched the assertion on value lives outside
implicit val podName: String = pod.getMetadata.getName
implicit val components: KubernetesTestComponents = kubernetesTestComponents
val env = Eventually.eventually(TIMEOUT, INTERVAL) {
try {
println("Looping...")
println(s"Checking env of ${pod.getMetadata().getName()} ....")
Utils.executeCommand("env")
} catch {
case e: Exception =>
println("The snoop boop failed!")
println(e)
e.printStackTrace()
throw e
}
}
println("Env contains " + env.toString)
assert(env.toString.contains(ENV_SECRET_VALUE_1))
assert(env.toString.contains(ENV_SECRET_VALUE_2))
val fileUsernameContents = Utils
.executeCommand("cat", s"$SECRET_MOUNT_PATH/$ENV_SECRET_KEY_1")
val filePasswordContents = Utils
.executeCommand("cat", s"$SECRET_MOUNT_PATH/$ENV_SECRET_KEY_2")
println("Secrets are " + fileUsernameContents.toString + "," + filePasswordContents.toString)
assert(fileUsernameContents.toString.trim.equals(ENV_SECRET_VALUE_1))
assert(filePasswordContents.toString.trim.equals(ENV_SECRET_VALUE_2))

println("Success!")
}
}

Expand Down