Skip to content

[SPARK-29107][SQL][TESTS] Port window.sql (Part 1) #25816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DylanGuedes wants to merge 8 commits into from
Closed

[SPARK-29107][SQL][TESTS] Port window.sql (Part 1) #25816

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df2a00a
adds first part of window split
DylanGuedes Sep 17, 2019
e23bced
add new changes to window_part1
DylanGuedes Sep 29, 2019
3d2c538
update to rel4
DylanGuedes Sep 29, 2019
589ddf6
remove query that didnt pass on thrift
DylanGuedes Sep 29, 2019
2eafd2c
update golden file
DylanGuedes Sep 29, 2019
1062e9c
change queries
DylanGuedes Oct 2, 2019
3a5825c
regen golden file
DylanGuedes Oct 8, 2019
1ac60f1
bump window file version and add new jiras
DylanGuedes Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change queries 
Signed-off-by: DylanGuedes <[email protected]>
  • Loading branch information
@DylanGuedes
DylanGuedes committed Oct 8, 2019
commit 1062e9ce00afd064155d5fe7d6220f4d468984bb
14 changes: 7 additions & 7 deletions sql/core/src/test/resources/sql-tests/inputs/pgSQL/window_part1.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,17 +187,17 @@ sum(ten) over (partition by four order by ten range between unbounded preceding
last(ten) over (partition by four order by ten range between unbounded preceding and unbounded following)
FROM (select distinct ten, four from tenk1) ss;

SELECT four, ten/4 as two,
sum(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row),
last(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row)
FROM (select distinct ten, four from tenk1) ss;

-- Failing on thrift server
Copy link
Member

@dongjoon-hyun dongjoon-hyun Oct 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a JIRA issue if we are not going to cover this query, too.

-- SELECT four, ten/4 as two,
-- sum(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row),
-- last(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row)
-- sum(ten/4) over (partition by four order by ten/4 rows between unbounded preceding and current row),
-- last(ten/4) over (partition by four order by ten/4 rows between unbounded preceding and current row)
-- FROM (select distinct ten, four from tenk1) ss;

SELECT four, ten/4 as two,
sum(ten/4) over (partition by four order by ten/4 rows between unbounded preceding and current row),
last(ten/4) over (partition by four order by ten/4 rows between unbounded preceding and current row)
FROM (select distinct ten, four from tenk1) ss;

SELECT sum(unique1) over (order by four range between current row and unbounded following),
unique1, four
FROM tenk1 WHERE unique1 < 10;
Expand Down
14 changes: 7 additions & 7 deletions sql/core/src/test/resources/sql-tests/results/pgSQL/window_part1.sql.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,30 +731,30 @@ struct<four:int,ten:int,sum(ten) OVER (PARTITION BY four ORDER BY ten ASC NULLS

-- !query 43
Copy link
Member

@HyukjinKwon HyukjinKwon Sep 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems failing when it's ran via the thrift server. Can you check the cause and exclude this in the test? cc @wangyum

SELECT four, ten/4 as two,
sum(ten/4) over (partition by four order by ten/4 rows between unbounded preceding and current row),
last(ten/4) over (partition by four order by ten/4 rows between unbounded preceding and current row)
sum(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row),
last(ten/4) over (partition by four order by ten/4 range between unbounded preceding and current row)
FROM (select distinct ten, four from tenk1) ss
-- !query 43 schema
struct<four:int,two:int,sum((ten div 4)) OVER (PARTITION BY four ORDER BY (ten div 4) ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW):bigint,last((ten div 4), false) OVER (PARTITION BY four ORDER BY (ten div 4) ASC NULLS FIRST ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW):int>
struct<four:int,two:int,sum((ten div 4)) OVER (PARTITION BY four ORDER BY (ten div 4) ASC NULLS FIRST RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW):bigint,last((ten div 4), false) OVER (PARTITION BY four ORDER BY (ten div 4) ASC NULLS FIRST RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW):int>
-- !query 43 output
0 0 0 0
0 0 0 0
0 1 1 1
0 1 2 1
0 1 2 1
0 2 4 2
1 0 0 0
1 0 0 0
1 1 1 1
1 1 2 1
1 1 2 1
1 2 4 2
2 0 0 0
2 0 0 0
2 1 1 1
2 1 2 1
2 1 2 1
2 2 4 2
3 0 0 0
3 0 0 0
3 1 1 1
3 1 2 1
3 1 2 1
3 2 4 2

Expand Down