Skip to content

[SPARK-29121][ML][MLLIB] Support for dot product operation on Vector(s) #25818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phpisciuneri wants to merge 6 commits into from
Closed

[SPARK-29121][ML][MLLIB] Support for dot product operation on Vector(s) #25818

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f906c3c
support dot product in ml.linalg.Vectors
phpisciuneri Sep 17, 2019
2f73684
support dot product in mllib.linalg.Vectors
phpisciuneri Sep 17, 2019
db41e0b
add annotations and use double brackets for types in doc
phpisciuneri Sep 18, 2019
475922d
use Vector dot method for Vectors.dot
phpisciuneri Sep 18, 2019
7cd1fc5
test Vector dot method for IllegalArgumentException
phpisciuneri Sep 18, 2019
9d2959b
delete extra routines
phpisciuneri Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use Vector dot method for Vectors.dot
  • Loading branch information
@phpisciuneri
phpisciuneri committed Sep 18, 2019
commit 475922dfd0f9da03a33dd262b32ea5a471ee1803
2 changes: 1 addition & 1 deletion mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ object Vectors {
* If `size` does not match an [[IllegalArgumentException]] is thrown.
*/
@Since("3.0.0")
def dot(v1: Vector, v2: Vector): Double = BLAS.dot(v1, v2)
def dot(v1: Vector, v2: Vector): Double = v1.dot(v2)

/**
* Creates a vector of all zeros.
Expand Down
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ object Vectors {
* If `size` does not match an [[IllegalArgumentException]] is thrown.
*/
@Since("3.0.0")
def dot(v1: Vector, v2: Vector): Double = BLAS.dot(v1, v2)
def dot(v1: Vector, v2: Vector): Double = v1.dot(v2)

/**
* Creates a vector of all zeros.
Expand Down