Skip to content

[SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership #26068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 5 commits into from
Closed

[SPARK-29405][SQL] Alter table / Insert statements should not change a table's ownership #26068

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f408912
[SPARK-29405][SQL] Alter table / Insert statements should not change …
yaooqinn Oct 9, 2019
a6721ca
fix ut
yaooqinn Oct 12, 2019
a990a31
add an unit test
yaooqinn Oct 17, 2019
0743ddd
fix ut
yaooqinn Oct 17, 2019
10cb13b
rm unsed import
yaooqinn Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add an unit test
  • Loading branch information
@yaooqinn
yaooqinn committed Oct 17, 2019
commit a990a3138d8a3079d6d01e9fec30f26cd15dbe76
13 changes: 13 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,19 @@ class VersionsSuite extends SparkFunSuite with Logging {
assert(client.getTable("default", "src").properties.contains("changed"))
}

test(s"$version: alterTable - should respect the original catalog table's owner name") {
val ownerName = "SPARK-29405"
val originalTable = client.getTable("default", "src")
// mocking the owner is what we declared
val newTable = originalTable.copy(owner = ownerName)
client.alterTable(newTable)
assert(client.getTable("default", "src") === ownerName)
// mocking the owner is empty
val newTable2 = originalTable.copy(owner = "")
client.alterTable(newTable2)
assert(client.getTable("default", "src") === client.userName)
}

test(s"$version: alterTable(dbName: String, tableName: String, table: CatalogTable)") {
val newTable = client.getTable("default", "src").copy(properties = Map("changedAgain" -> ""))
client.alterTable("default", "src", newTable)
Expand Down