Skip to content

[SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default #26107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengliangwang wants to merge 15 commits into from
Closed

[SPARK-28885][SQL] Follow ANSI store assignment rules in table insertion by default #26107

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ae40a71
making ANSI store assignment policy as default
gengliangwang Oct 14, 2019
6f9cfa1
fix test failures
gengliangwang Oct 14, 2019
ad8f578
fix one more test failure
gengliangwang Oct 14, 2019
758ac1f
fix failure
gengliangwang Oct 14, 2019
28c49e7
fix more failures
gengliangwang Oct 14, 2019
3d80200
more fixes
gengliangwang Oct 14, 2019
4bd989e
add migration guide
gengliangwang Oct 14, 2019
944a426
fix more test failures
gengliangwang Oct 14, 2019
24056b9
fix
gengliangwang Oct 14, 2019
b602083
fix
gengliangwang Oct 14, 2019
cb70ddc
fix more failure
gengliangwang Oct 14, 2019
e24e35d
Revert "fix"
gengliangwang Oct 14, 2019
e7ccbac
Revert "fix more failure"
gengliangwang Oct 14, 2019
4b77736
fix one more failure
gengliangwang Oct 15, 2019
b9abb67
recover one test case
gengliangwang Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
recover one test case
  • Loading branch information
@gengliangwang
gengliangwang committed Oct 15, 2019
commit b9abb67cd9761e59ee62ecb77b269deb725b1185
6 changes: 3 additions & 3 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveSerDeReadWriteSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
hiveClient.runSqlHive(s"CREATE TABLE hive_serde (c1 TIMESTAMP) STORED AS $fileFormat")
hiveClient.runSqlHive("INSERT INTO TABLE hive_serde values('2019-04-11 15:50:00')")
checkAnswer(spark.table("hive_serde"), Row(Timestamp.valueOf("2019-04-11 15:50:00")))
spark.sql("INSERT INTO TABLE hive_serde values('2019-04-12 15:50:00')")
spark.sql("INSERT INTO TABLE hive_serde values(TIMESTAMP('2019-04-12 15:50:00'))")
checkAnswer(
spark.table("hive_serde"),
Seq(Row(Timestamp.valueOf("2019-04-11 15:50:00")),
Expand All @@ -77,7 +77,7 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
hiveClient.runSqlHive(s"CREATE TABLE hive_serde (c1 DATE) STORED AS $fileFormat")
hiveClient.runSqlHive("INSERT INTO TABLE hive_serde values('2019-04-11')")
checkAnswer(spark.table("hive_serde"), Row(Date.valueOf("2019-04-11")))
spark.sql("INSERT INTO TABLE hive_serde values('2019-04-12')")
spark.sql("INSERT INTO TABLE hive_serde values(TIMESTAMP('2019-04-12'))")
checkAnswer(
spark.table("hive_serde"),
Seq(Row(Date.valueOf("2019-04-11")), Row(Date.valueOf("2019-04-12"))))
Expand Down Expand Up @@ -170,7 +170,7 @@ class HiveSerDeReadWriteSuite extends QueryTest with SQLTestUtils with TestHiveS
// Date/Time Types
// SPARK-28885 String value is not allowed to be stored as date/timestamp type with
// ANSI store assignment policy.
// checkDateTimeTypes(fileFormat)
checkDateTimeTypes(fileFormat)

// String Types
checkStringTypes(fileFormat, "STRING", "s1")
Expand Down