-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29490][SQL] Reset 'WritableColumnVector' in 'RowToColumnarExec' #26137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok to test |
|
do we have a unit test? |
|
Good catch, yes they need to be reset when reused. |
Not yet. I can add one if needed. |
|
Test build #112161 has finished for PR 26137 at commit
|
|
Test build #112200 has finished for PR 26137 at commit
|
|
Test build #112245 has finished for PR 26137 at commit
|
|
@cloud-fan Could you help to review this? I've added one unit test. |
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
Show resolved
Hide resolved
|
Welcome to the Apache Spark community, @rongma1997 ! I left a few comments. |
|
cc @gatorsmile |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Merged to master.
Thank you all.
|
You are added to the Apache Spark contributor group, @rongma1997 . |
What changes were proposed in this pull request?
Reset the
WritableColumnVectorwhen getting "next" ColumnarBatch inRowToColumnarExecWhy are the changes needed?
When converting
Iterator[InternalRow]toIterator[ColumnarBatch], the vectors used to create a newColumnarBatchshould be reset in the iterator's "next()" method.Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A