Skip to content

[SPARK-29529][DOCS]Remove unnecessary orc version and hive version in doc #26146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denglingang wants to merge 5 commits into from
Closed

[SPARK-29529][DOCS]Remove unnecessary orc version and hive version in doc #26146

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2badd47
Fix ORC version
denglingang Oct 17, 2019
25dcd2c
Remove ORC version
denglingang Oct 18, 2019
6974b7f
Remove hive version
denglingang Oct 21, 2019
806edae
Remove hive version in SQLConf.scala
denglingang Oct 22, 2019
c5ddd1e
Fix a typo
HyukjinKwon Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sql-data-sources-orc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ the vectorized reader is used when `spark.sql.hive.convertMetastoreOrc` is also
<tr>
<td><code>spark.sql.orc.impl</code></td>
<td><code>native</code></td>
<td>The name of ORC implementation. It can be one of <code>native</code> and <code>hive</code>. <code>native</code> means the native ORC support that is built on Apache ORC 1.4. `hive` means the ORC library in Hive 1.2.1.</td>
<td>The name of ORC implementation. It can be one of <code>native</code> and <code>hive</code>. <code>native</code> means the native ORC support that is built on Apache ORC 1.5. `hive` means the ORC library in Hive 1.2.1.</td>
Copy link
Member

@srowen srowen Oct 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove versions from this statement entirely? it's not the right place

Copy link
Member

@dongjoon-hyun dongjoon-hyun Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for removal.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Oct 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ur, BTW, it seems that we need to rewrite all. Hive 1.2.1 also became wrong because Hadoop 3.2 profile means ORC 1.6, too. Oops. Late duplicated comment.

cc @wangyum

</tr>
<tr>
<td><code>spark.sql.orc.enableVectorizedReader</code></td>
Expand Down