[SPARK-29515][Core] MapStatuses SerDeser Benchmark #26169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * {{{ | ||
| * To run this benchmark: | ||
| * 1. without sbt: bin/spark-submit --class <this class> | ||
| * --jars <catalyst test jar>,<core test jar> |
| import org.apache.commons.io.FileUtils | ||
| benchmark.out.println("Compressed Serialized MapStatus sizes: " + | ||
| FileUtils.byteCountToDisplaySize(serializedMapStatusSizes)) | ||
| benchmark.out.println(s"Compressed Serialized Broadcast MapStatus sizes: " + |
Member
|
I'll make the generate result PR to your branch soon. |
Member
|
Hi, @dbtsai . |
EC2 Benchmark result (JDK11/8)
dongjoon-hyun
changed the title
Member
Author
|
@dongjoon-hyun thanks for benchmark result and review! |
dongjoon-hyun
approved these changes
Oct 18, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thanks, @dbtsai
Member
|
Also, cc @wangyum since this is a new JDK8/11 benchmark in |
|
Test build #112293 has finished for PR 26169 at commit
|
Member
|
Thank you @dbtsai @dongjoon-hyun |
|
Test build #112297 has finished for PR 26169 at commit
|
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. --> Add benchmark code for MapStatuses serialization & deserialization performance. For comparing the performance differences against optimization. <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If no, write 'No'. --> No <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> No test is required. Closes apache#26169 from dbtsai/benchmark. Lead-authored-by: DB Tsai <[email protected]> Co-authored-by: Dongjoon Hyun <[email protected]> Co-authored-by: DB Tsai <[email protected]> Signed-off-by: DB Tsai <[email protected]> Ref: LIHADOOP-56788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add benchmark code for MapStatuses serialization & deserialization performance.
Why are the changes needed?
For comparing the performance differences against optimization.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No test is required.