Skip to content

[SPARK-29504][WebUI] Toggle full job description on click #26222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PavithraRamachandran wants to merge 2 commits into from
Closed

[SPARK-29504][WebUI] Toggle full job description on click #26222

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf030b
show full decription when double click on ellipse
PavithraRamachandran Oct 23, 2019
c07c0b3
review comment updation
PavithraRamachandran Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
show full decription when double click on ellipse
  • Loading branch information
@PavithraRamachandran
PavithraRamachandran committed Oct 23, 2019
commit caf030bbb3da8c16727f89fd29f2385ddc7d5e7b
9 changes: 8 additions & 1 deletion core/src/main/resources/org/apache/spark/ui/static/webui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,11 @@ $(function() {
collapseTablePageLoad('collapse-aggregated-runningExecutions','aggregated-runningExecutions');
collapseTablePageLoad('collapse-aggregated-completedExecutions','aggregated-completedExecutions');
collapseTablePageLoad('collapse-aggregated-failedExecutions','aggregated-failedExecutions');
});
});

$(function() {
// Trigger a double click on the span to show full job description.
$(".description-input").dblclick(function() {
$(this).removeClass("description-input").addClass("description-input-full");
});
});
Copy link
Member

@wangyum wangyum Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We supported this feature before. https://github.com/apache/spark/pull/25374/files#diff-c794386db0ef43c8090b67c83cf6b950L81-L89

Copy link
Member

@wangyum wangyum Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @gengliangwang @sarutak

Copy link
Contributor Author

@PavithraRamachandran PavithraRamachandran Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangyum yes. It was present. But
https://github.com/apache/spark/pull/25374/files
removed additonal-metrics.js whch had the function for this double click event.
So this feature was broken.

Copy link
Member

@wangyum wangyum Oct 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update your changes to

$(function() {
    // Show/hide full job description on click event.	
    $(".description-input").click(function() {	
        $(this).toggleClass("description-input-full");	
    });
});

Copy link
Contributor Author

@PavithraRamachandran PavithraRamachandran Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangyum i have changed. could you check