Skip to content

[SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect #26230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fuwhu wants to merge 6 commits into from
Closed

[SPARK-21287][SQL] Move the validation of fetch size from JDBCOptions to JdbcDialect #26230

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
df889aa
Move the validation of fetch size from JDBCOptions to JdbcDialect
fuwhu Oct 23, 2019
b6f3cae
Change JdbcDialect.validateFetchSize to be protected.
fuwhu Oct 23, 2019
7316549
Refine the parameter of JdbcDialect.validateFetchSize.
fuwhu Oct 23, 2019
78e89c4
Fix typo.
fuwhu Oct 24, 2019
f65191f
Move all valdiation logic to JdbcDialects.validateProperties and remo…
fuwhu Oct 24, 2019
74f0325
1. Move import of JavaConverters to header of JDBCRDD.
fuwhu Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change JdbcDialect.validateFetchSize to be protected.
  • Loading branch information
@fuwhu
fuwhu committed Oct 23, 2019
commit b6f3cae11dea3f6524203e4f65520fb855921eed
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ abstract class JdbcDialect extends Serializable {
* requirement of different dialects.
* @param properties The connection properties. This is passed through from the relation.
*/
def validateFetchSize(properties: Map[String, String]): Unit = {
protected def validateFetchSize(properties: Map[String, String]): Unit = {
val size = properties.getOrElse(JDBCOptions.JDBC_BATCH_FETCH_SIZE, "0").toInt
require(size >= 0,
s"Invalid value `${size.toString}` for parameter " +
Expand Down