Skip to content

[SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite #26234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
07ARB wants to merge 1 commit into from
Closed

[SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite #26234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[SPARK-29571][SQL][TESTS][FOLLOWUP]Fix UT in AllExecutionsPageSuite c… 
…lass

 ###What changes were proposed in this pull request?
 This is a follow-up of #24052 to correct assert condition.

 ###Why are the changes needed?
 To test IllegalArgumentException condition..

 ###Does this PR introduce any user-facing change?
 No.

 ###How was this patch tested?
 Manual Test (during fixing of SPARK-29453 find this issue)

Author: 07ARB <[email protected]>
  • Loading branch information
@07ARB
07ARB committed Oct 23, 2019
commit cce2fccc825d64a0d6302b9eeab387671a9c1336
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class AllExecutionsPageSuite extends SharedSparkSession with BeforeAndAfter {
map.put("failed.sort", Array("duration"))
when(request.getParameterMap()).thenReturn(map)
val html = renderSQLPage(request, tab, statusStore).toString().toLowerCase(Locale.ROOT)
assert(!html.contains("IllegalArgumentException"))
assert(!html.contains("illegalargumentexception"))
Copy link
Member

@HyukjinKwon HyukjinKwon Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, how come the tests passed before, @07ARB?

Copy link
Contributor

@HeartSaVioR HeartSaVioR Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the problem was that the assertion effectively doesn't verify anything - finding upper&lower string from lowercased string.

Copy link
Member

@HyukjinKwon HyukjinKwon Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, I misread :-).

assert(html.contains("duration"))
}

Expand Down