-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29614][SQL][TEST] Fix failures of DateTimeUtilsSuite and TimestampFormatterSuite #26273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #112728 has finished for PR 26273 at commit
|
|
Test build #112729 has finished for PR 26273 at commit
|
Member
Author
|
ping @dongjoon-hyun @srowen |
srowen
approved these changes
Oct 27, 2019
|
Test build #112733 has finished for PR 26273 at commit
|
dongjoon-hyun
approved these changes
Oct 27, 2019
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member
|
Is this only affecting the master branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
DateTimeUtilsSuiteandTimestampFormatterSuiteassume constant time difference betweentimestamp'yesterday',timestamp'today'andtimestamp'tomorrow'which is wrong on daylight switching day - day length can be 23 or 25 hours. In the PR, I propose to use Java 8 time API to calculate instances ofyesterdayandtomorrowtimestamps.Why are the changes needed?
The changes fix test failures and make the tests tolerant to daylight time switching.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By existing test suites
DateTimeUtilsSuiteandTimestampFormatterSuite.