Skip to content

[SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper #26397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HeartSaVioR wants to merge 5 commits into from
Closed

[SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogInfo & AttemptInfoWrapper #26397

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f505521
[SPARK-29755][CORE] Provide @JsonDeserialize for Option[Long] in LogI…
HeartSaVioR Nov 5, 2019
ae2e43c
Add UT which fails on master branch and passes with the patch
HeartSaVioR Nov 6, 2019
8ba7014
Reflect review comment
HeartSaVioR Nov 6, 2019
c665983
Reflect review comments
HeartSaVioR Nov 8, 2019
698a657
Reflect review comment
HeartSaVioR Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reflect review comment
  • Loading branch information
@HeartSaVioR
HeartSaVioR committed Nov 10, 2019
commit 698a6571e6f798b74d8469be32b41999c5397d60
2 changes: 1 addition & 1 deletion core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,7 +1325,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
if (expected.isEmpty) {
assert(opt.isEmpty)
} else {
// The issue happens only the value in Option is being unboxed. Here we ensure unboxing
// The issue happens only when the value in Option is being unboxed. Here we ensure unboxing
// to Long succeeds: even though IDE suggests `.toLong` is redundant, direct comparison
// doesn't trigger unboxing and passes even without SPARK-29755, so don't remove
// `.toLong` below. Please refer SPARK-29755 for more details.
Expand Down