[SPARK-3775] Not suitable error message in spark-shell.cmd #2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified some sentence of error message in bin\*.cmd.
Member
|
I don't agree that users should be directed to build with SBT. Maven is the default, but, probably best to not even make a specific recommendation. |
|
Can one of the admins verify this patch? |
Contributor
Author
|
Yes, so I removed the specific recommendation for SBT. |
Member
|
Oh I'm sorry, my poor brain read the diff the wrong way around. I agree with the change! |
Contributor
|
Ok, LGTM. This is going into master and 1.1. |
asfgit
pushed a commit
that referenced
this pull request
Oct 3, 2014
Modified some sentence of error message in bin\*.cmd. Author: Masayoshi TSUZUKI <[email protected]> Closes #2640 from tsudukim/feature/SPARK-3775 and squashes the following commits: 3458afb [Masayoshi TSUZUKI] [SPARK-3775] Not suitable error message in spark-shell.cmd (cherry picked from commit 358d7ff) Signed-off-by: Andrew Or <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified some sentence of error message in bin*.cmd.