Skip to content

[SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values #26449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yaooqinn wants to merge 14 commits into from
Closed

[SPARK-29822][SQL] Fix cast error when there are white spaces between signs and values #26449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b1b2f7c
[SPARK-29605][SQL][FOLLOWUP] Fix cast error when there are spaces bet…
yaooqinn Nov 9, 2019
71acf0a
Merge remote-tracking branch 'origin/master' into SPARK-29605
yaooqinn Nov 9, 2019
8f0dba0
benchmark and unit tests
yaooqinn Nov 9, 2019
925e8e7
benchmark with jdk 1.8.0_231-b11
yaooqinn Nov 10, 2019
65e2a1c
benchmark with jdk-11.0.5
yaooqinn Nov 10, 2019
200fd5d
Revert "benchmark with jdk-11.0.5"
yaooqinn Nov 10, 2019
8851f35
fix jdk11 result
yaooqinn Nov 10, 2019
48d168d
Merge branch 'master' into SPARK-29605
yaooqinn Nov 11, 2019
1e8272c
regen golden file
yaooqinn Nov 11, 2019
cb8aa6b
add TRIM_UNIT
yaooqinn Nov 11, 2019
0a301a1
naming
yaooqinn Nov 11, 2019
83b9ae3
naming again
yaooqinn Nov 11, 2019
34bf719
naming again
yaooqinn Nov 11, 2019
cb83761
tests
yaooqinn Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark with jdk-11.0.5
  • Loading branch information
@yaooqinn
yaooqinn committed Nov 10, 2019
commit 65e2a1c09746bb64acdc1e77dae542b91bba045c
48 changes: 26 additions & 22 deletions sql/core/benchmarks/IntervalBenchmark-jdk11-results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,29 @@
OpenJDK 64-Bit Server VM 11.0.2+9 on Mac OS X 10.15.1
Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
Java HotSpot(TM) 64-Bit Server VM 1.8.0_231-b11 on Mac OS X 10.14.6
Intel(R) Core(TM) i5-5287U CPU @ 2.90GHz
cast strings to intervals: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
prepare string w/ interval 442 472 41 2.3 442.4 1.0X
prepare string w/o interval 420 423 6 2.4 419.6 1.1X
1 units w/ interval 350 359 9 2.9 349.8 1.3X
1 units w/o interval 316 317 1 3.2 316.4 1.4X
2 units w/ interval 457 459 2 2.2 457.0 1.0X
2 units w/o interval 432 435 3 2.3 432.2 1.0X
3 units w/ interval 610 613 3 1.6 609.8 0.7X
3 units w/o interval 581 583 2 1.7 580.5 0.8X
4 units w/ interval 720 724 4 1.4 720.4 0.6X
4 units w/o interval 699 704 8 1.4 699.4 0.6X
5 units w/ interval 850 850 0 1.2 849.9 0.5X
5 units w/o interval 829 832 5 1.2 828.7 0.5X
6 units w/ interval 927 932 4 1.1 927.1 0.5X
6 units w/o interval 891 892 1 1.1 890.5 0.5X
7 units w/ interval 1033 1040 8 1.0 1033.2 0.4X
7 units w/o interval 1020 1024 5 1.0 1020.2 0.4X
8 units w/ interval 1168 1169 2 0.9 1168.0 0.4X
8 units w/o interval 1155 1157 2 0.9 1154.5 0.4X
9 units w/ interval 1326 1328 3 0.8 1326.1 0.3X
9 units w/o interval 1372 1381 14 0.7 1372.5 0.3X
prepare string w/ interval 707 930 269 1.4 706.8 1.0X
prepare string w/o interval 660 759 141 1.5 659.7 1.1X
1 units w/ interval 526 777 263 1.9 526.0 1.3X
1 units w/o interval 453 462 8 2.2 453.4 1.6X
2 units w/ interval 636 663 23 1.6 636.5 1.1X
2 units w/o interval 643 655 19 1.6 643.4 1.1X
3 units w/ interval 1160 1186 31 0.9 1160.4 0.6X
3 units w/o interval 1136 1212 76 0.9 1135.6 0.6X
4 units w/ interval 1316 1401 124 0.8 1316.4 0.5X
4 units w/o interval 1284 1297 11 0.8 1284.4 0.6X
5 units w/ interval 1404 1412 8 0.7 1404.0 0.5X
5 units w/o interval 1404 1407 3 0.7 1404.2 0.5X
6 units w/ interval 1585 1591 7 0.6 1585.1 0.4X
6 units w/o interval 1577 1580 3 0.6 1576.8 0.4X
7 units w/ interval 1798 1807 8 0.6 1797.6 0.4X
7 units w/o interval 1785 1794 15 0.6 1784.7 0.4X
8 units w/ interval 1939 1952 16 0.5 1939.2 0.4X
8 units w/o interval 1921 1926 6 0.5 1920.8 0.4X
9 units w/ interval 1965 1972 11 0.5 1964.5 0.4X
9 units w/o interval 1954 1964 14 0.5 1954.0 0.4X
10 units w/ interval 2107 2112 6 0.5 2107.5 0.3X
10 units w/o interval 2099 2107 7 0.5 2099.0 0.3X
11 units w/ interval 2297 2298 1 0.4 2296.8 0.3X
11 units w/o interval 2300 2349 84 0.4 2300.1 0.3X

29 changes: 0 additions & 29 deletions sql/core/benchmarks/IntervalBenchmark-results.txt
View file
Open in desktop

This file was deleted.