Skip to content

[MINOR][TESTS] Ignore GitHub Action and AppVeyor file changes in testing #26556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 3 commits into from
Closed

[MINOR][TESTS] Ignore GitHub Action and AppVeyor file changes in testing #26556

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70fa59b
[MINOR][TESTS] Ignore GitHub Action and AppVeyor files
dongjoon-hyun Nov 16, 2019
0a55273
fix appveyor.yml
dongjoon-hyun Nov 16, 2019
f64d060
fix indentation
dongjoon-hyun Nov 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dev/run-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,20 @@ def determine_modules_for_files(filenames):
"""
Given a list of filenames, return the set of modules that contain those files.
If a file is not associated with a more specific submodule, then this method will consider that
file to belong to the 'root' module.
file to belong to the 'root' module. GitHub Action and Appveyor files are ignored.

>>> sorted(x.name for x in determine_modules_for_files(["python/pyspark/a.py", "sql/core/foo"]))
['pyspark-core', 'sql']
>>> [x.name for x in determine_modules_for_files(["file_not_matched_by_any_subproject"])]
['root']
>>> [x.name for x in determine_modules_for_files( \
[".github/workflows/master.yml", "appveyor.yml"])]
Copy link
Member

@HyukjinKwon HyukjinKwon Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no big deal but it is usually:

    >>> [x.name for x in determine_modules_for_files(
    ...     [".github/workflows/master.yml", "appveyor.yml"])]

[]
"""
changed_modules = set()
for filename in filenames:
if filename in (".github/workflows/master.yml", "appveyor.yml"):
continue
matched_at_least_one_module = False
for module in modules.all_modules:
if module.contains_file(filename):
Expand Down