Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 23, 2019

What changes were proposed in this pull request?

This PR aims to update test-dependencies.sh to validate all available Hadoop/Hive combination.

Why are the changes needed?

Previously, we have been checking only Hadoop2.7/Hive1.2 and Hadoop3.2/Hive2.3.
We need to validate Hadoop2.7/Hive2.3 additionally for Apache Spark 3.0.

Does this PR introduce any user-facing change?

No. (This is a dev-only change).

How was this patch tested?

Pass the GitHub Action (Linter) with the newly updated manifest because this is only dependency check.

@dongjoon-hyun
Copy link
Member Author

cc @srowen , @liancheng , @HyukjinKwon , @wangyum

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30005][INFRA] Update test-dependencies.sh to check hive-1.2/2.3 profile [WIP][SPARK-30005][INFRA] Update test-dependencies.sh to check hive-1.2/2.3 profile Nov 23, 2019
@dongjoon-hyun dongjoon-hyun changed the title [WIP][SPARK-30005][INFRA] Update test-dependencies.sh to check hive-1.2/2.3 profile [SPARK-30005][INFRA] Update test-dependencies.sh to check hive-1.2/2.3 profile Nov 23, 2019
@SparkQA
Copy link

SparkQA commented Nov 23, 2019

Test build #114321 has finished for PR 26646 at commit 5eef37a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 23, 2019

Test build #114323 has finished for PR 26646 at commit 5a4513b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Hi, could you review this please, @maropu ?

@dongjoon-hyun
Copy link
Member Author

Hi, @srowen .
Could you review this PR, please?

@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen !
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-30005 branch November 24, 2019 18:14
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks fine to me too

@maropu
Copy link
Member

maropu commented Dec 2, 2019

Ur, I missed ping... sorry. late LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants