Skip to content

Conversation

@MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Jan 14, 2020

What changes were proposed in this pull request?

In the PR, I propose to remove the header option in the Avro source v2: support partition pruning test.

Why are the changes needed?

The option is not supported by Avro, and may misleading readers.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By AvroSuite.

@MaxGekk
Copy link
Member Author

MaxGekk commented Jan 14, 2020

This follows up #27200 (review) , @dongjoon-hyun Please, take a look at this PR.

@SparkQA
Copy link

SparkQA commented Jan 14, 2020

Test build #116724 has finished for PR 27203 at commit efa306f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! +1, LGTM. Merged to master.

@MaxGekk MaxGekk deleted the avro-suite-remove-header-option branch June 5, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants