Skip to content

[WIP][SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 #27328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zero323 wants to merge 10 commits into from
+57 −30
Closed

[WIP][SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 #27328

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1027538
Switch to testthat >= 2.0.0
zero323 Jan 22, 2020
5fb017c
Skip collect() support Unicode character on Windows
zero323 Jan 24, 2020
097ea52
Disable recursive call check
zero323 Jan 24, 2020
6281c0f
Move test data to external file
zero323 Jan 24, 2020
3bb15aa
Force 2.0
zero323 Jan 24, 2020
5468b4b
Re-enable support Unicode characters
zero323 Jan 24, 2020
e02d85e
Set repos
zero323 Jan 24, 2020
0265727
Switch to double quotes
zero323 Jan 24, 2020
abcaf3d
Be more explicit about required version
zero323 Jan 24, 2020
684831b
Switch to source
zero323 Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-enable support Unicode characters
  • Loading branch information
@zero323
zero323 committed Jan 24, 2020
commit 5468b4b347a0fe6581cdbf68f1f8fa0a8da9dd07
4 changes: 0 additions & 4 deletions R/pkg/tests/fulltests/test_sparkSQL.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,10 +848,6 @@ test_that("collect() and take() on a DataFrame return the same number of rows an
})

test_that("collect() support Unicode characters", {
if (is_windows()) {
skip("Shouldn't be executed on Windows due to input encoding issues")
}

jsonPath <- file.path(
Sys.getenv("SPARK_HOME"),
"R", "pkg", "tests", "fulltests", "data",
Expand Down