Skip to content

Conversation

@sryza
Copy link
Contributor

@sryza sryza commented Oct 10, 2014

I triggered the issue and verified the message gets printed on a pseudo-distributed cluster.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have started for PR 2744 at commit af11185.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 10, 2014

QA tests have finished for PR 2744 at commit af11185.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21564/Test PASSed.

@tgravescs
Copy link
Contributor

Jenkins, test this please.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we don't print the diagnostics message here also?

@sryza
Copy link
Contributor Author

sryza commented Oct 30, 2014

Updated patch incorporates review comments

@tgravescs
Copy link
Contributor

looks good. thanks @sryza!

@asfgit asfgit closed this in acd4ac7 Oct 31, 2014
@shivaram
Copy link
Contributor

@sryza
Copy link
Contributor Author

sryza commented Oct 31, 2014

I'll look into it

On Oct 31, 2014, at 12:36 PM, Shivaram Venkataraman [email protected] wrote:

This patch seems to have broken the build ? See https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-Maven-with-YARN/HADOOP_PROFILE=hadoop-2.4,label=centos/821/console for an example


Reply to this email directly or view it on GitHub.

@shivaram
Copy link
Contributor

I have a commit to just comment out the test at https://github.com/shivaram/spark-1/compare/fix-yarn-build?expand=1 -- But if you have a better fix, we can use that.

@jdanbrown
Copy link

@sryza I came across your PR while searching for ways to debug pyspark yarn containers running over yarn memory limits. This change will be very helpful; what are your thoughts on dumping the container process listing as well, like yarn MR tasks do? That's killer for figuring out which process in your container is out of control, like in the case of pyspark where you have a jvm and python processes to deal with.

Example:

@sryza
Copy link
Contributor Author

sryza commented Nov 12, 2014

@jdanbrown that seems reasonable. Mind filing a JIRA for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants