Skip to content

Conversation

@JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Feb 10, 2020

What changes were proposed in this pull request?

This is a follow up in #27452.
Add a unit test to verify whether the log warning is print when intentionally skip AQE.

Why are the changes needed?

Add unit test

Does this PR introduce any user-facing change?

No

How was this patch tested?

adding unit test

@JkSelf
Copy link
Contributor Author

JkSelf commented Feb 10, 2020

@cloud-fan @gatorsmile

@SparkQA
Copy link

SparkQA commented Feb 10, 2020

Test build #118114 has finished for PR 27515 at commit 98806c7.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JkSelf
Copy link
Contributor Author

JkSelf commented Feb 10, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Feb 10, 2020

Test build #118137 has finished for PR 27515 at commit 98806c7.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan cloud-fan closed this in 5a24060 Feb 10, 2020
@cloud-fan
Copy link
Contributor

This is a test-only PR and is not related to pyspark. Merging to master/3.0, thanks!

@cloud-fan cloud-fan changed the title [SPARK-30719][SQL] Add unit test to verify the log warning print when intentionally skip AQE [SPARK-30719][SQL][TEST] Add unit test to verify the log warning print when intentionally skip AQE Feb 10, 2020
cloud-fan pushed a commit that referenced this pull request Feb 10, 2020
… intentionally skip AQE

### What changes were proposed in this pull request?

This is a follow up in [#27452](#27452).
Add a unit test to verify whether the log warning is print when intentionally skip AQE.

### Why are the changes needed?

Add unit test

### Does this PR introduce any user-facing change?

No

### How was this patch tested?

adding unit test

Closes #27515 from JkSelf/aqeLoggingWarningTest.

Authored-by: jiake <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit 5a24060)
Signed-off-by: Wenchen Fan <[email protected]>
sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
… intentionally skip AQE

### What changes were proposed in this pull request?

This is a follow up in [apache#27452](apache#27452).
Add a unit test to verify whether the log warning is print when intentionally skip AQE.

### Why are the changes needed?

Add unit test

### Does this PR introduce any user-facing change?

No

### How was this patch tested?

adding unit test

Closes apache#27515 from JkSelf/aqeLoggingWarningTest.

Authored-by: jiake <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants