Skip to content

[SPARK-28869][DOCS][FOLLOWUP] Add direct relationship between configs for rolling event log #27576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HeartSaVioR wants to merge 2 commits into from
Closed

[SPARK-28869][DOCS][FOLLOWUP] Add direct relationship between configs for rolling event log #27576

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5760af9
[SPARK-28869][DOCS][FOLLOWUP] Add direct relationship between configs…
HeartSaVioR Feb 14, 2020
705d129
Adapt existing style
HeartSaVioR Feb 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/scala/org/apache/spark/internal/config/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ package object config {

private[spark] val EVENT_LOG_ROLLING_MAX_FILE_SIZE =
ConfigBuilder("spark.eventLog.rolling.maxFileSize")
.doc("The max size of event log file to be rolled over.")
.doc(s"Precondition: ${EVENT_LOG_ENABLE_ROLLING.key}. " +
Copy link
Member

@HyukjinKwon HyukjinKwon Feb 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I saw the new PR #27575. We could match how we describe there. Shall we also fix docs/configuration.md?

Copy link
Contributor Author

@HeartSaVioR HeartSaVioR Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I missed we have equivalent description in doc as well. Will update as well.

"The max size of event log file to be rolled over.")
.bytesConf(ByteUnit.BYTE)
.checkValue(_ >= ByteUnit.MiB.toBytes(10), "Max file size of event log should be " +
"configured to be at least 10 MiB.")
Expand Down