Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix build fails
  • Loading branch information
MaxGekk committed Feb 24, 2020
commit 15bedb39a026bc00eb5fa85affb0858bdce8e724
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import java.util.concurrent.TimeUnit
import scala.util.control.NonFatal

import org.apache.spark.sql.catalyst.util.DateTimeConstants._
import org.apache.spark.sql.catalyst.util.DateTimeUtils.fromMillis
import org.apache.spark.sql.catalyst.util.DateTimeUtils.millisToMicros
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.Decimal
import org.apache.spark.unsafe.types.{CalendarInterval, UTF8String}
Expand Down Expand Up @@ -705,7 +705,7 @@ object IntervalUtils {
microseconds = Math.addExact(microseconds, minutesUs)
i += minuteStr.numBytes()
} else if (s.matchAt(millisStr, i)) {
val millisUs = fromMillis(currentValue)
val millisUs = millisToMicros(currentValue)
microseconds = Math.addExact(microseconds, millisUs)
i += millisStr.numBytes()
} else if (s.matchAt(microsStr, i)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class LegacyFastTimestampFormatter(
}
val micros = cal.getMicros()
cal.set(Calendar.MILLISECOND, 0)
Math.addExact(fromMillis(cal.getTimeInMillis), micros)
Math.addExact(millisToMicros(cal.getTimeInMillis), micros)
}

def format(timestamp: SQLTimestamp): String = {
Expand All @@ -164,7 +164,7 @@ class LegacySimpleTimestampFormatter(
}

override def parse(s: String): Long = {
fromMillis(sdf.parse(s).getTime)
millisToMicros(sdf.parse(s).getTime)
}

override def format(us: Long): String = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,13 +271,13 @@ abstract class CastSuiteBase extends SparkFunSuite with ExpressionEvalHelper {
checkEvaluation(
cast(cast(new Timestamp(c.getTimeInMillis), StringType, timeZoneId),
TimestampType, timeZoneId),
fromMillis(c.getTimeInMillis))
millisToMicros(c.getTimeInMillis))
c = Calendar.getInstance(TimeZoneGMT)
c.set(2015, 10, 1, 2, 30, 0)
checkEvaluation(
cast(cast(new Timestamp(c.getTimeInMillis), StringType, timeZoneId),
TimestampType, timeZoneId),
fromMillis(c.getTimeInMillis))
millisToMicros(c.getTimeInMillis))
}

val gmtId = Option("GMT")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {

test("SPARK-6785: java date conversion before and after epoch") {
def format(d: Date): String = {
TimestampFormatter("uuuu-MM-dd", defaultTimeZone().toZoneId).format(fromMillis(d.getTime))
TimestampFormatter("uuuu-MM-dd", defaultTimeZone().toZoneId)
.format(millisToMicros(d.getTime))
}
def checkFromToJavaDate(d1: Date): Unit = {
val d2 = toJavaDate(fromJavaDate(d1))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import java.util.concurrent.TimeUnit
import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.catalyst.plans.SQLHelper
import org.apache.spark.sql.catalyst.util.DateTimeConstants._
import org.apache.spark.sql.catalyst.util.DateTimeUtils.fromMillis
import org.apache.spark.sql.catalyst.util.DateTimeUtils.millisToMicros
import org.apache.spark.sql.catalyst.util.IntervalUtils._
import org.apache.spark.sql.catalyst.util.IntervalUtils.IntervalUnit._
import org.apache.spark.sql.internal.SQLConf
Expand Down Expand Up @@ -77,7 +77,7 @@ class IntervalUtilsSuite extends SparkFunSuite with SQLHelper {
testSingleUnit("HouR", 3, 0, 0, 3 * MICROS_PER_HOUR)
testSingleUnit("MiNuTe", 3, 0, 0, 3 * MICROS_PER_MINUTE)
testSingleUnit("Second", 3, 0, 0, 3 * MICROS_PER_SECOND)
testSingleUnit("MilliSecond", 3, 0, 0, fromMillis(3))
testSingleUnit("MilliSecond", 3, 0, 0, millisToMicros(3))
testSingleUnit("MicroSecond", 3, 0, 0, 3)

checkFromInvalidString(null, "cannot be null")
Expand Down Expand Up @@ -176,7 +176,7 @@ class IntervalUtilsSuite extends SparkFunSuite with SQLHelper {
new CalendarInterval(
0,
10,
12 * MICROS_PER_MINUTE + fromMillis(888)))
12 * MICROS_PER_MINUTE + millisToMicros(888)))
assert(fromDayTimeString("-3 0:0:0") === new CalendarInterval(0, -3, 0L))

try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import org.apache.spark.rdd.RDD
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions.{Attribute, UnsafeProjection}
import org.apache.spark.sql.catalyst.plans.logical.EventTimeWatermark
import org.apache.spark.sql.catalyst.util.DateTimeUtils.toMillis
import org.apache.spark.sql.catalyst.util.DateTimeUtils.microsToMillis
import org.apache.spark.sql.execution.{SparkPlan, UnaryExecNode}
import org.apache.spark.sql.types.MetadataBuilder
import org.apache.spark.unsafe.types.CalendarInterval
Expand Down Expand Up @@ -100,7 +100,7 @@ case class EventTimeWatermarkExec(
child.execute().mapPartitions { iter =>
val getEventTime = UnsafeProjection.create(eventTime :: Nil, child.output)
iter.map { row =>
eventTimeStats.add(toMillis(getEventTime(row).getLong(0)))
eventTimeStats.add(microsToMillis(getEventTime(row).getLong(0)))
row
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import java.util.concurrent.TimeUnit
import scala.concurrent.duration.Duration

import org.apache.spark.sql.catalyst.util.DateTimeConstants.MICROS_PER_DAY
import org.apache.spark.sql.catalyst.util.DateTimeUtils.toMillis
import org.apache.spark.sql.catalyst.util.DateTimeUtils.microsToMillis
import org.apache.spark.sql.catalyst.util.IntervalUtils
import org.apache.spark.sql.streaming.Trigger
import org.apache.spark.unsafe.types.UTF8String
Expand All @@ -38,7 +38,7 @@ private object Triggers {
throw new IllegalArgumentException(s"Doesn't support month or year interval: $interval")
}
val microsInDays = Math.multiplyExact(cal.days, MICROS_PER_DAY)
toMillis(Math.addExact(cal.microseconds, microsInDays))
microsToMillis(Math.addExact(cal.microseconds, microsInDays))
}

def convert(interval: Duration): Long = interval.toMillis
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ abstract class StatisticsCollectionTestBase extends QueryTest with SQLTestUtils
private val d2 = Date.valueOf(d2Str)
private val t1Str = "2016-05-08 00:00:01.000000"
private val t1Internal = date(2016, 5, 8, 0, 0, 1)
private val t1 = new Timestamp(DateTimeUtils.toMillis(t1Internal))
private val t1 = new Timestamp(DateTimeUtils.microsToMillis(t1Internal))
private val t2Str = "2016-05-09 00:00:02.000000"
private val t2Internal = date(2016, 5, 9, 0, 0, 2)
private val t2 = new Timestamp(DateTimeUtils.toMillis(t2Internal))
private val t2 = new Timestamp(DateTimeUtils.microsToMillis(t2Internal))

/**
* Define a very simple 3 row table used for testing column serialization.
Expand Down