Skip to content

[SPARK-31153][BUILD] Cleanup several failures in lint-python #27910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nchammas wants to merge 7 commits into from
Closed

[SPARK-31153][BUILD] Cleanup several failures in lint-python #27910

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
26b01bf
add function for doing minimum version check
nchammas Mar 14, 2020
a150f27
use consistent VERSION naming + don't suppress errors!
nchammas Mar 14, 2020
51488cf
check expected versions using new function
nchammas Mar 14, 2020
abe157e
use vendored packaging lib
nchammas Mar 14, 2020
9b543b0
restore flake8 version extraction
nchammas Mar 14, 2020
02184d3
typo -> EXPECTED_PYDOCSTYLE
nchammas Mar 14, 2020
5ad9396
quote consistently
nchammas Mar 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add function for doing minimum version check
  • Loading branch information
@nchammas
nchammas committed Mar 14, 2020
commit 26b01bf84d5a7e9cdbb9b3a450072c3133f5269a
11 changes: 11 additions & 0 deletions dev/lint-python
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,17 @@ SPHINX_BUILD="sphinx-build"

PYTHON_EXECUTABLE="python3"

function satisfies_min_version {
local provided_version="$1"
local expected_version="$2"
echo "$(
"$PYTHON_EXECUTABLE" << EOM
from packaging import version
print(version.parse('$provided_version') >= version.parse('$expected_version'))
EOM
)"
}

function compile_python_test {
local COMPILE_STATUS=
local COMPILE_REPORT=
Expand Down