[SPARK-31153][BUILD][3.0] Cleanup several failures in lint-python #27917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR cleans up several failures -- most of them silent -- in `dev/lint-python`. I don't understand how we haven't been bitten by these yet. Perhaps we've been lucky?
Fixes include:
* Fix how we compare versions. All the version checks currently in `master` silently fail with:
```
File "<string>", line 2
print(LooseVersion("""2.3.1""") >= LooseVersion("""2.4.0"""))
^
IndentationError: unexpected indent
```
Another problem is that `distutils.version` is undocumented and unsupported.
* Fix some basic bugs. e.g. We have an incorrect reference to `$PYDOCSTYLEBUILD`, which doesn't exist, which was causing the doc style test to silently fail with:
```
./dev/lint-python: line 193: --version: command not found
```
* Stop suppressing error output! It's hiding problems and serves no purpose here.
`lint-python` is part of our CI build and is currently doing any combination of the following: silently failing; incorrectly skipping tests; incorrectly downloading libraries when a suitable library is already available.
No.
Lots of manual testing with `set -x` enabled.
Closes apache#27910 from nchammas/SPARK-31153-lint-python.
Authored-by: Nicholas Chammas <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
HyukjinKwon
changed the title
Contributor
Author
|
cc @HyukjinKwon. It's my first time backporting a change. Did I do it right? Contributing guide doesn't say much about how to do it. |
HyukjinKwon
approved these changes
Mar 15, 2020
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
LGTM pending Jenkins and Github Action tests, assuming it's also manually tested (e.g., version checking when it's not installed)
Member
|
@nchammas sure, looks good! one nit in the PR title I fixed. |
Contributor
Author
Can confirm I tested it manually with |
|
Test build #119810 has finished for PR 27917 at commit
|
Contributor
Author
|
Retest this please. |
|
Test build #119814 has finished for PR 27917 at commit
|
Member
|
Merged to branch-3.0. Thank you @nchammas for working on this. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 16, 2020
Backport of #27910 / 0ce5519. --- This PR cleans up several failures -- most of them silent -- in `dev/lint-python`. I don't understand how we haven't been bitten by these yet. Perhaps we've been lucky? Fixes include: * Fix how we compare versions. All the version checks currently in `master` silently fail with: ``` File "<string>", line 2 print(LooseVersion("""2.3.1""") >= LooseVersion("""2.4.0""")) ^ IndentationError: unexpected indent ``` Another problem is that `distutils.version` is undocumented and unsupported. * Fix some basic bugs. e.g. We have an incorrect reference to `$PYDOCSTYLEBUILD`, which doesn't exist, which was causing the doc style test to silently fail with: ``` ./dev/lint-python: line 193: --version: command not found ``` * Stop suppressing error output! It's hiding problems and serves no purpose here. `lint-python` is part of our CI build and is currently doing any combination of the following: silently failing; incorrectly skipping tests; incorrectly downloading libraries when a suitable library is already available. Closes #27917 from nchammas/SPARK-31153-lint-python-branch-3.0. Authored-by: Nicholas Chammas <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #27910 / 0ce5519.
This PR cleans up several failures -- most of them silent -- in
dev/lint-python. I don't understand how we haven't been bitten by these yet. Perhaps we've been lucky?Fixes include:
Fix how we compare versions. All the version checks currently in
mastersilently fail with:Another problem is that
distutils.versionis undocumented and unsupported.Fix some basic bugs. e.g. We have an incorrect reference to
$PYDOCSTYLEBUILD, which doesn't exist, which was causing the doc style test to silently fail with:Stop suppressing error output! It's hiding problems and serves no purpose here.
lint-pythonis part of our CI build and is currently doing any combination of the following: silently failing; incorrectly skipping tests; incorrectly downloading libraries when a suitable library is already available.