Skip to content

[SPARK-31238][SQL] Rebase dates to/from Julian calendar in write/read for ORC datasource #28016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 7 commits into from
Closed

[SPARK-31238][SQL] Rebase dates to/from Julian calendar in write/read for ORC datasource #28016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a2a081a
Add a test
MaxGekk Mar 25, 2020
121b4c6
Fix v2.3 OrcColumnVector
MaxGekk Mar 25, 2020
ecef05d
Fix v1.2 OrcColumnVector
MaxGekk Mar 25, 2020
47d8588
Rebase in write
MaxGekk Mar 25, 2020
29d7966
Copy DaysWritable to v1.2
MaxGekk Mar 26, 2020
3b1b791
Remove `index` variable in OrcColumnVector
MaxGekk Mar 26, 2020
c8a897a
Added a comment to `DaysWritable` v1.2
MaxGekk Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add a test
  • Loading branch information
@MaxGekk
MaxGekk committed Mar 25, 2020
commit a2a081a11655e0622973e75658a7f5830a0ff6fb
Binary file added sql/core/src/test/resources/test-data/before_1582_date_v2_4.snappy.orc
View file
Open in desktop
Binary file not shown.
10 changes: 10 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,16 @@ abstract class OrcSuite extends OrcTest with BeforeAndAfterAll {
}
}
}

test("SPARK-31238: compatibility with Spark 2.4 in reading dates") {
Seq(false, true).foreach { vectorized =>
withSQLConf(SQLConf.ORC_VECTORIZED_READER_ENABLED.key -> vectorized.toString) {
checkAnswer(
readResourceOrcFile("test-data/before_1582_date_v2_4.snappy.orc"),
Row(java.sql.Date.valueOf("1200-01-01")))
}
}
}
}

class OrcSourceSuite extends OrcSuite with SharedSparkSession {
Expand Down
5 changes: 5 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,9 @@ abstract class OrcTest extends QueryTest with FileBasedDataSourceTest with Befor
throw new AnalysisException("Can not match OrcTable in the query.")
}
}

protected def readResourceOrcFile(name: String): DataFrame = {
val url = Thread.currentThread().getContextClassLoader.getResource(name)
spark.read.orc(url.toString)
}
}