Skip to content

[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource #28047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 2 commits into from
Closed

[SPARK-31284][SQL][TESTS] Check rebasing of timestamps in ORC datasource #28047

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
143f9a1
Check rebasing of timestamps in ORC datasource
MaxGekk Mar 27, 2020
5a04bbf
Update JIRA id
MaxGekk Mar 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Check rebasing of timestamps in ORC datasource
  • Loading branch information
@MaxGekk
MaxGekk committed Mar 27, 2020
commit 143f9a1364a343c66b1024d64f04aec84ceecc7d
Binary file added sql/core/src/test/resources/test-data/before_1582_ts_v2_4.snappy.orc
View file
Open in desktop
Binary file not shown.
28 changes: 28 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,34 @@ abstract class OrcSuite extends OrcTest with BeforeAndAfterAll {
}
}
}

test("SPARK-31238: compatibility with Spark 2.4 in reading timestamps") {
Seq(false, true).foreach { vectorized =>
withSQLConf(SQLConf.ORC_VECTORIZED_READER_ENABLED.key -> vectorized.toString) {
checkAnswer(
readResourceOrcFile("test-data/before_1582_ts_v2_4.snappy.orc"),
Row(java.sql.Timestamp.valueOf("1001-01-01 01:02:03.123456")))
}
}
}

test("SPARK-31238: rebasing timestamps in write") {
withTempPath { dir =>
val path = dir.getAbsolutePath
Seq("1001-01-01 01:02:03.123456").toDF("tsS")
.select($"tsS".cast("timestamp").as("ts"))
.write
.orc(path)

Seq(false, true).foreach { vectorized =>
withSQLConf(SQLConf.ORC_VECTORIZED_READER_ENABLED.key -> vectorized.toString) {
checkAnswer(
spark.read.orc(path),
Row(java.sql.Timestamp.valueOf("1001-01-01 01:02:03.123456")))
}
}
}
}
}

class OrcSourceSuite extends OrcSuite with SharedSparkSession {
Expand Down