Skip to content

[SPARK-31416][SQL] Check more strictly that a field name can be used as a valid Java identifier for codegen #28184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 4 commits into from
Closed

[SPARK-31416][SQL] Check more strictly that a field name can be used as a valid Java identifier for codegen #28184

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
602c8c9
Strictly check that a field name can be used as a valid identifier.
sarutak Apr 10, 2020
14bb7ba
Fixed genjavadoc error.
sarutak Apr 10, 2020
eef0532
Added another indentation.
sarutak Apr 12, 2020
a42b169
Move test cases for Java keywords check to ScalaReflectionRelationSuite.
sarutak Apr 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed genjavadoc error.
  • Loading branch information
@sarutak
sarutak committed Apr 10, 2020
commit 14bb7ba56d9ae6fcbed0f4b6e90407b388d14f61
4 changes: 3 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ class DatasetSuite extends QueryTest

private implicit val ordering = Ordering.by((c: ClassData) => c.a -> c.b)

// To avoid syntax error thrown by genjavadoc, make this case class non-top level and private.
private case class InvalidInJava2(`0`: Int)

test("checkAnswer should compare map correctly") {
val data = Seq((1, "2", Map(1 -> 2, 2 -> 1)))
checkAnswer(
Expand Down Expand Up @@ -1971,7 +1974,6 @@ case class NestedStruct(f: ClassData)
case class DeepNestedStruct(f: NestedStruct)

case class InvalidInJava(`abstract`: Int)
case class InvalidInJava2(`0`: Int)

/**
* A class used to test serialization using encoders. This class throws exceptions when using
Expand Down