[SPARK-31234][SQL][FOLLOW-UP] ResetCommand should not affect static SQL Configuration #28265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatorsmile
commented
Apr 19, 2020
|
|
||
| - The `org.apache.spark.ExecutorPlugin` interface and related configuration has been replaced with | ||
| `org.apache.spark.plugin.SparkPlugin`, which adds new functionality. Plugins using the old | ||
| `org.apache.spark.api.plugin.SparkPlugin`, which adds new functionality. Plugins using the old |
gatorsmile
commented
Apr 19, 2020
|
Test build #121489 has finished for PR 28265 at commit
|
Member
|
Yea, the fix looks fine if the relevant test failure fixed. |
yaooqinn
approved these changes
Apr 20, 2020
gatorsmile
commented
Apr 20, 2020
|
|
||
| assert(session.sessionState.conf.getConfString("spark.app.name") === "test-app-SPARK-31234") | ||
| assert(session.sessionState.conf.getConf(GLOBAL_TEMP_DATABASE) === "globalTempDB-SPARK-31234") | ||
| assert(session.sessionState.conf.getConf(GLOBAL_TEMP_DATABASE) === "globaltempdb-spark-31234") |
Member
Author
There was a problem hiding this comment.
This difference between Spark 2.4 and Spark 3.0 is caused by #24979
Member
Author
|
cc @cloud-fan |
Contributor
|
LGTM |
|
Test build #121501 has finished for PR 28265 at commit
|
Member
|
retest this please |
HyukjinKwon
approved these changes
Apr 20, 2020
dongjoon-hyun
approved these changes
Apr 20, 2020
|
Test build #121506 has finished for PR 28265 at commit
|
Member
|
retest this please |
|
Test build #121529 has finished for PR 28265 at commit
|
gatorsmile
added a commit
that referenced
this pull request
Apr 20, 2020
…QL Configuration ### What changes were proposed in this pull request? This PR is the follow-up PR of #28003 - add a migration guide - add an end-to-end test case. ### Why are the changes needed? The original PR made the major behavior change in the user-facing RESET command. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Added a new end-to-end test Closes #28265 from gatorsmile/spark-31234followup. Authored-by: gatorsmile <[email protected]> Signed-off-by: gatorsmile <[email protected]> (cherry picked from commit 6c792a7) Signed-off-by: gatorsmile <[email protected]>
Member
Author
|
Thanks! Merged to master and 3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is the follow-up PR of #28003
Why are the changes needed?
The original PR made the major behavior change in the user-facing RESET command.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a new end-to-end test