Skip to content

[SPARK-31534][WEBUI] Text for tooltip should be escaped. #28317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 4 commits into from
Closed

[SPARK-31534][WEBUI] Text for tooltip should be escaped. #28317

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a40056e
Escaped text for tooltip.
sarutak Apr 23, 2020
e01d458
Added a testcase.
sarutak Apr 23, 2020
d3690bd
Fixed node label for StagePage.
sarutak Apr 23, 2020
3b8b071
Fixed a testcase.
sarutak Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed a testcase.
  • Loading branch information
@sarutak
sarutak committed Apr 24, 2020
commit 3b8b0716e6ba86e53773f4884fc41d6d04b77780
14 changes: 7 additions & 7 deletions core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,29 +688,29 @@ class UISeleniumSuite extends SparkFunSuite with WebBrowser with Matchers with B
assert(stage0.contains("digraph G {\n subgraph clusterstage_0 {\n " +
"label="Stage 0";\n subgraph "))
assert(stage0.contains("{\n label="parallelize";\n " +
"0 [label="ParallelCollectionRDD [0]"))
"0 [labelType="html" label="ParallelCollectionRDD [0]"))
assert(stage0.contains("{\n label="map";\n " +
"1 [label="MapPartitionsRDD [1]"))
"1 [labelType="html" label="MapPartitionsRDD [1]"))
assert(stage0.contains("{\n label="groupBy";\n " +
"2 [label="MapPartitionsRDD [2]"))
"2 [labelType="html" label="MapPartitionsRDD [2]"))

val stage1 = Source.fromURL(sc.ui.get.webUrl +
"/stages/stage/?id=1&attempt=0&expandDagViz=true").mkString
assert(stage1.contains("digraph G {\n subgraph clusterstage_1 {\n " +
"label="Stage 1";\n subgraph "))
assert(stage1.contains("{\n label="groupBy";\n " +
"3 [label="ShuffledRDD [3]"))
"3 [labelType="html" label="ShuffledRDD [3]"))
assert(stage1.contains("{\n label="map";\n " +
"4 [label="MapPartitionsRDD [4]"))
"4 [labelType="html" label="MapPartitionsRDD [4]"))
assert(stage1.contains("{\n label="groupBy";\n " +
"5 [label="MapPartitionsRDD [5]"))
"5 [labelType="html" label="MapPartitionsRDD [5]"))

val stage2 = Source.fromURL(sc.ui.get.webUrl +
"/stages/stage/?id=2&attempt=0&expandDagViz=true").mkString
assert(stage2.contains("digraph G {\n subgraph clusterstage_2 {\n " +
"label="Stage 2";\n subgraph "))
assert(stage2.contains("{\n label="groupBy";\n " +
"6 [label="ShuffledRDD [6]"))
"6 [labelType="html" label="ShuffledRDD [6]"))
}
}
}
Expand Down