Skip to content

[SPARK-31565][WEBUI] Unify the font color of label among all DAG-viz #28352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 1 commit into from
Closed

[SPARK-31565][WEBUI] Unify the font color of label among all DAG-viz #28352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/resources/org/apache/spark/ui/static/spark-dag-viz.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#dag-viz-graph .label {
font-weight: normal;
text-shadow: none;
color: #333;
Copy link
Member

@dongjoon-hyun dongjoon-hyun Apr 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change?

According to the PR description, For RDDs, the color is #212529 which is specified by bootstrap.min.js.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Apr 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I validate this overrides correctly via Web Inspector and UI.

Copy link
Member Author

@sarutak sarutak Apr 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the library DAG-viz uses (dagre-d3) has some mode.
One is text which is the default mode and another is html mode.
With html mode, label is represented as HTML, while with text mode, label is represented as SVG.
For each node in DAG-viz for RDDs, outer label is SVG and inner one is HTML.
The color of font for SVG is specified by fill while color for HTML so we need this setting.
stage-graph-fixed

While I wrote the explanation above, I noticed the font color of outer node for query plans is not specified. So, the default font color of SVG seems to be applied (Can you recognize the color of WholeStageCodegen (1) is a little bit darker than SerializeFromObject ?).
plan-graph-fixed

I'll create a followup PR.

}

#dag-viz-graph svg path {
Expand Down
2 changes: 1 addition & 1 deletion sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
font-size: 0.85rem;
font-weight: normal;
text-shadow: none;
color: black;
color: #333;
}

#plan-viz-graph svg g.cluster rect {
Expand Down